You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/03 23:41:30 UTC

Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 

Diff: https://reviews.apache.org/r/16589/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On Jan. 14, 2014, 11:27 a.m., Vinod Kone wrote:
> > Is there a test for this?

It's not quite easy to compare the Futures returned through dispatch() but it's rather straightforward to verify the code. What do you think?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/#review31763
-----------------------------------------------------------


On Jan. 3, 2014, 3:36 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16589/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 3:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-892
>     https://issues.apache.org/jira/browse/MESOS-892
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
>   src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 
> 
> Diff: https://reviews.apache.org/r/16589/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/#review31763
-----------------------------------------------------------

Ship it!


Is there a test for this?


src/master/contender.hpp
<https://reviews.apache.org/r/16589/#comment60488>

    s/Recontending/Recontending after candidacy is obtained/ ?



src/master/contender.cpp
<https://reviews.apache.org/r/16589/#comment60489>

    new line.


- Vinod Kone


On Jan. 3, 2014, 11:36 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16589/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 11:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-892
>     https://issues.apache.org/jira/browse/MESOS-892
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
>   src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 
> 
> Diff: https://reviews.apache.org/r/16589/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/#review31783
-----------------------------------------------------------

Ship it!



src/master/contender.hpp
<https://reviews.apache.org/r/16589/#comment60504>

    "otherwise the future for the pending election is returned." ("previous" here seems a bit misleading)


- Ben Mahler


On Jan. 3, 2014, 11:36 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16589/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 11:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-892
>     https://issues.apache.org/jira/browse/MESOS-892
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
>   src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 
> 
> Diff: https://reviews.apache.org/r/16589/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 11:33 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Added a test.

MESOS_VERBOSE=1 GLOG_v=2 ./bin/mesos-tests.sh -j --gtest_filter=ZooKeeperMasterContenderDetectorTest.ContenderPendingElection --gtest_repeat=100 --gtest_break_on_failure


Bugs: MESOS-892
    https://issues.apache.org/jira/browse/MESOS-892


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
  src/master/contender.cpp 72a779617139fe8ad018396014e4a2e45bd45471 
  src/tests/master_contender_detector_tests.cpp d532c17c64c4c797053616cb486a907855bb723b 

Diff: https://reviews.apache.org/r/16589/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/#review31896
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Jan. 15, 2014, 12:49 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16589/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 12:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-892
>     https://issues.apache.org/jira/browse/MESOS-892
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
>   src/master/contender.cpp 72a779617139fe8ad018396014e4a2e45bd45471 
> 
> Diff: https://reviews.apache.org/r/16589/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 4:49 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-892
    https://issues.apache.org/jira/browse/MESOS-892


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
  src/master/contender.cpp 72a779617139fe8ad018396014e4a2e45bd45471 

Diff: https://reviews.apache.org/r/16589/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 11:36 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-892
    https://issues.apache.org/jira/browse/MESOS-892


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
  src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 

Diff: https://reviews.apache.org/r/16589/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu