[GitHub] [spark] srowen commented on a change in pull request #26982: [SPARK-30329][ML] add iterator/foreach methods for Vectors

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26982: [SPARK-30329][ML] add iterator/foreach methods for Vectors
URL: https://github.com/apache/spark/pull/26982#discussion_r360933151
 
 

 ##########
 File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala
 ##########
 @@ -753,6 +782,39 @@ class SparseVector @Since("2.0.0") (
     }.unzip
     new SparseVector(selectedIndices.length, sliceInds.toArray, sliceVals.toArray)
   }
+
+  @Since("3.0.0")
+  override def iterator: Iterator[(Int, Double)] = {
 
 Review comment:
   Can we just make this optimization rather than expose all these new API methods? I'm not clear we want to expose the 'iterator' vs 'foreachX' style. Why is this faster BTW?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org