You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/12/19 19:27:10 UTC
Review Request 29259: [PREVIEW] Distribute Repository/Install:
multiple improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29259/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
Bugs: AMBARI-8834
https://issues.apache.org/jira/browse/AMBARI-8834
Repository: ambari
Description
-------
This jira scopes on 3 aspects of Distribute Repository/Install Packages:
- fix parallel install for zypper/apt
- refactor repo file content (all repositories for a single repo version should be in a single file)
- remove installed packages if some package installation fails
TODO:
- not rebased on latest trunk yet (have to merge)
- not finished unit test
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariAgent.py e029620
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 61997f2
ambari-agent/src/main/python/ambari_agent/Facter.py 41a84af
ambari-agent/src/main/python/ambari_agent/Hardware.py 4f6e756
ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85d
ambari-agent/src/main/python/ambari_agent/PackagesAnalyzer.py 93f3e89
ambari-agent/src/main/python/ambari_agent/ProcessHelper.py ae3345d
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 2ba492f
ambari-agent/src/main/python/ambari_agent/StatusCheck.py 7feadb6
ambari-agent/src/main/python/ambari_agent/main.py 80d0b77
ambari-agent/src/main/python/ambari_agent/shell.py 2022646
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 46c0166
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a5f085b
ambari-agent/src/test/python/ambari_agent/TestMain.py dce94df
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d1bec5d
ambari-agent/src/test/python/ambari_agent/TestShell.py a839932
ambari-agent/src/test/python/resource_management/TestPackageResource.py a357d46
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 4e4871a
ambari-common/src/main/python/resource_management/core/providers/package/apt.py 33814d8
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c447225
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py fb0b862
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/providers/repository.py fc95fb3
ambari-common/src/main/python/resource_management/libraries/resources/repository.py 48a347a
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py e6057e4
ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 d486f89
ambari-server/src/test/python/custom_actions/TestInstallPackages.py c7ec155
Diff: https://reviews.apache.org/r/29259/diff/
Testing
-------
That is a preview of patch
End-to-end testing in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 29259: [PREVIEW] Distribute Repository/Install
packages: multiple improvements
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29259/#review66706
-----------------------------------------------------------
Ship it!
Looks ok to me.
- Nate Cole
On Dec. 19, 2014, 1:27 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29259/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 1:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8834
> https://issues.apache.org/jira/browse/AMBARI-8834
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This jira scopes on 3 aspects of Distribute Repository/Install Packages:
> - fix parallel install for zypper/apt
> - refactor repo file content (all repositories for a single repo version should be in a single file)
> - remove installed packages if some package installation fails
>
> TODO:
> - not rebased on latest trunk yet (have to merge)
> - not finished unit test
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariAgent.py e029620
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 61997f2
> ambari-agent/src/main/python/ambari_agent/Facter.py 41a84af
> ambari-agent/src/main/python/ambari_agent/Hardware.py 4f6e756
> ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85d
> ambari-agent/src/main/python/ambari_agent/PackagesAnalyzer.py 93f3e89
> ambari-agent/src/main/python/ambari_agent/ProcessHelper.py ae3345d
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 2ba492f
> ambari-agent/src/main/python/ambari_agent/StatusCheck.py 7feadb6
> ambari-agent/src/main/python/ambari_agent/main.py 80d0b77
> ambari-agent/src/main/python/ambari_agent/shell.py 2022646
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 46c0166
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a5f085b
> ambari-agent/src/test/python/ambari_agent/TestMain.py dce94df
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d1bec5d
> ambari-agent/src/test/python/ambari_agent/TestShell.py a839932
> ambari-agent/src/test/python/resource_management/TestPackageResource.py a357d46
> ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 4e4871a
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py 33814d8
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c447225
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py fb0b862
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/providers/repository.py fc95fb3
> ambari-common/src/main/python/resource_management/libraries/resources/repository.py 48a347a
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py e6057e4
> ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 d486f89
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py c7ec155
>
> Diff: https://reviews.apache.org/r/29259/diff/
>
>
> Testing
> -------
>
> That is a preview of patch
> End-to-end testing in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 29259: [PREVIEW] Distribute Repository/Install
packages: multiple improvements
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29259/
-----------------------------------------------------------
(Updated Jan. 5, 2015, 7:57 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
Bugs: AMBARI-8834
https://issues.apache.org/jira/browse/AMBARI-8834
Repository: ambari
Description (updated)
-------
Reviewboard misbehaved at the time of commit. Final patch is attached to Apache jira.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariAgent.py e029620
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 61997f2
ambari-agent/src/main/python/ambari_agent/Facter.py 41a84af
ambari-agent/src/main/python/ambari_agent/Hardware.py 4f6e756
ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85d
ambari-agent/src/main/python/ambari_agent/PackagesAnalyzer.py 93f3e89
ambari-agent/src/main/python/ambari_agent/ProcessHelper.py ae3345d
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 2ba492f
ambari-agent/src/main/python/ambari_agent/StatusCheck.py 7feadb6
ambari-agent/src/main/python/ambari_agent/main.py 80d0b77
ambari-agent/src/main/python/ambari_agent/shell.py 2022646
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 46c0166
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a5f085b
ambari-agent/src/test/python/ambari_agent/TestMain.py dce94df
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d1bec5d
ambari-agent/src/test/python/ambari_agent/TestShell.py a839932
ambari-agent/src/test/python/resource_management/TestPackageResource.py a357d46
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 4e4871a
ambari-common/src/main/python/resource_management/core/providers/package/apt.py 33814d8
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c447225
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py fb0b862
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/providers/repository.py fc95fb3
ambari-common/src/main/python/resource_management/libraries/resources/repository.py 48a347a
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py e6057e4
ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 d486f89
ambari-server/src/test/python/custom_actions/TestInstallPackages.py c7ec155
Diff: https://reviews.apache.org/r/29259/diff/
Testing
-------
That is a preview of patch
End-to-end testing in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 29259: [PREVIEW] Distribute Repository/Install
packages: multiple improvements
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29259/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 6:27 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
Summary (updated)
-----------------
[PREVIEW] Distribute Repository/Install packages: multiple improvements
Bugs: AMBARI-8834
https://issues.apache.org/jira/browse/AMBARI-8834
Repository: ambari
Description
-------
This jira scopes on 3 aspects of Distribute Repository/Install Packages:
- fix parallel install for zypper/apt
- refactor repo file content (all repositories for a single repo version should be in a single file)
- remove installed packages if some package installation fails
TODO:
- not rebased on latest trunk yet (have to merge)
- not finished unit test
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariAgent.py e029620
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 61997f2
ambari-agent/src/main/python/ambari_agent/Facter.py 41a84af
ambari-agent/src/main/python/ambari_agent/Hardware.py 4f6e756
ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85d
ambari-agent/src/main/python/ambari_agent/PackagesAnalyzer.py 93f3e89
ambari-agent/src/main/python/ambari_agent/ProcessHelper.py ae3345d
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 2ba492f
ambari-agent/src/main/python/ambari_agent/StatusCheck.py 7feadb6
ambari-agent/src/main/python/ambari_agent/main.py 80d0b77
ambari-agent/src/main/python/ambari_agent/shell.py 2022646
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 46c0166
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a5f085b
ambari-agent/src/test/python/ambari_agent/TestMain.py dce94df
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d1bec5d
ambari-agent/src/test/python/ambari_agent/TestShell.py a839932
ambari-agent/src/test/python/resource_management/TestPackageResource.py a357d46
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 4e4871a
ambari-common/src/main/python/resource_management/core/providers/package/apt.py 33814d8
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c447225
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py fb0b862
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/providers/repository.py fc95fb3
ambari-common/src/main/python/resource_management/libraries/resources/repository.py 48a347a
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py e6057e4
ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 d486f89
ambari-server/src/test/python/custom_actions/TestInstallPackages.py c7ec155
Diff: https://reviews.apache.org/r/29259/diff/
Testing
-------
That is a preview of patch
End-to-end testing in progress
Thanks,
Dmitro Lisnichenko