[GitHub] [cassandra-sidecar] nvharikrishna commented on a diff in pull request #42: CASSANDRASC-48: Adding new endpoint that gives information about the release version & partitioner name of a node

[GitBox <gi...@apache.org>]

nvharikrishna commented on code in PR #42:
URL: https://github.com/apache/cassandra-sidecar/pull/42#discussion_r1023158706


##########
common/src/main/java/org/apache/cassandra/sidecar/common/NodeStatus.java:
##########
@@ -19,10 +19,39 @@
 
 package org.apache.cassandra.sidecar.common;
 
+import com.fasterxml.jackson.annotation.JsonProperty;
+
 /**
- * Placeholder
+ * Holds information about the Status of a node
  */
 public class NodeStatus
 {
+    private final String releaseVersion;
+    private final String partitioner;
+
+    /**
+     * Constructs a new {@link NodeStatus} object with the Cassandra node's release version and partitioner
+     * information.
+     *
+     * @param releaseVersion the release version of the Cassandra node
+     * @param partitioner    the partitioner used by the Cassandra node
+     */
+    public NodeStatus(@JsonProperty("releaseVersion") String releaseVersion,
+                      @JsonProperty("partitioner") String partitioner)

Review Comment:
   Neither releaseVersion nor partitoner says node is up or down. Why this class is called as NodeStatus?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org