You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2019/01/30 21:32:18 UTC
Re: [sling-site] branch master updated: SLING-8175 minor HTML5
changes
Hi Jason and thanks for looking into the website's layout.
On Tue, 2019-01-29 at 18:12 +0000, jeb@apache.org wrote:
> diff --git a/src/main/jbake/assets/res/css/site.css
> b/src/main/jbake/assets/res/css/site.css
> index 60982e1..1406da7 100644
> --- a/src/main/jbake/assets/res/css/site.css
> +++ b/src/main/jbake/assets/res/css/site.css
> @@ -317,10 +317,22 @@ pre {
> padding-bottom:1em;
> }
>
> -.breadcrumbs {
> +.breadcrumb {
> float:left;
> }
>
> +.breadcrumb a {
> + text-decoration: none;
> +}
> +
> +.breadcrumb a:after {
> + padding-left: .4em;
> + padding-right: .4em;
> + content : "\BB";
> + color: #000;
> + display:inline-block;
> +}
I _think_ these changes cause the breadcrumbs to have a ">>" marker
even for the last breadcrumb, which looks slightly off.
Could you adjust the changes so that the ">>" marker only appears
between breadcrumbs and not after the last one?
Thanks,
Robert
Re: [sling-site] branch master updated: SLING-8175 minor HTML5
changes
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2019-01-31 at 08:15 -0500, Jason E Bailey wrote:
> No, the breadcrumbs always had a trailing '>>' I don't think it looks
> good either but my initial attempt was structural. The css is
> straightforward to have it show up just between the links. I'll have
> that in place today.
Ah, ok, sorry. Anyway, thanks for looking into this :-)
Robert
Re: [sling-site] branch master updated: SLING-8175 minor HTML5 changes
Posted by Jason E Bailey <ja...@24601.org>.
No, the breadcrumbs always had a trailing '>>' I don't think it looks good either but my initial attempt was structural. The css is straightforward to have it show up just between the links. I'll have that in place today.
--
Jason
On Wed, Jan 30, 2019, at 4:32 PM, Robert Munteanu wrote:
> Hi Jason and thanks for looking into the website's layout.
>
> On Tue, 2019-01-29 at 18:12 +0000, jeb@apache.org wrote:
> > diff --git a/src/main/jbake/assets/res/css/site.css
> > b/src/main/jbake/assets/res/css/site.css
> > index 60982e1..1406da7 100644
> > --- a/src/main/jbake/assets/res/css/site.css
> > +++ b/src/main/jbake/assets/res/css/site.css
> > @@ -317,10 +317,22 @@ pre {
> > padding-bottom:1em;
> > }
> >
> > -.breadcrumbs {
> > +.breadcrumb {
> > float:left;
> > }
> >
> > +.breadcrumb a {
> > + text-decoration: none;
> > +}
> > +
> > +.breadcrumb a:after {
> > + padding-left: .4em;
> > + padding-right: .4em;
> > + content : "\BB";
> > + color: #000;
> > + display:inline-block;
> > +}
>
> I _think_ these changes cause the breadcrumbs to have a ">>" marker
> even for the last breadcrumb, which looks slightly off.
>
> Could you adjust the changes so that the ">>" marker only appears
> between breadcrumbs and not after the last one?
>
> Thanks,
>
> Robert
>
>