You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/02/24 16:19:25 UTC
[GitHub] [thrift] alex-kormukhin opened a new pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
alex-kormukhin opened a new pull request #2534:
URL: https://github.com/apache/thrift/pull/2534
Fix [THRIFT-5519 Java async client loses exceptions in void methods](https://issues.apache.org/jira/browse/THRIFT-5519).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G merged pull request #2534:
URL: https://github.com/apache/thrift/pull/2534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1057367038
Tons of "no @param for ..." warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1057367038
Tons of "no @param for ..." warnings, and warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated. Not sure if they weren't there before already ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1052083356
Any idea why it fails?
> Plugin [id: 'com.github.johnrengelman.shadow', version: '4.0.4'] was not found in any of the following sources:
The latest version seems to be 2.x not 4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1052083356
Any idea why it fails?
> Plugin [id: 'com.github.johnrengelman.shadow', version: '4.0.4'] was not found in any of the following sources:
EDIT: Seems the plugin is simply outdated.
https://plugins.gradle.org/plugin/com.github.johnrengelman.plugin-shadow
Not to be confused with
https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1052092385
https://issues.apache.org/jira/browse/THRIFT-5530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1057367038
Tons of "no @param for ..." warnings, and warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated. Not sure if they weren't there before already ... yep, old warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1052083356
Any idea why it fails?
> Plugin [id: 'com.github.johnrengelman.shadow', version: '4.0.4'] was not found in any of the following sources:
The latest version seems to be 2.x not 4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on a change in pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on a change in pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#discussion_r815147701
##########
File path: test/VoidMethExceptionsTest.thrift
##########
@@ -0,0 +1,13 @@
+namespace java thrift.test.voidmethexceptions
+
+exception TExampleException {
+ 1: required string message;
+}
+
+service TAppService01 {
+ string returnString(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+ void returnVoidThrows(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+ void returnVoidNoThrowsRuntimeException(1: string msg, 2: bool throwException);
+ void returnVoidNoThrowsTApplicationException(1: string msg, 2: bool throwException);
+ oneway void onewayVoidNoThrows(1: string msg, 2: bool throwException);
Review comment:
Just to be clear: A oneway does not return anything. Including exceptions. There is no return. None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1057367038
Tons of "no @param for ..." warnings, and warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated. Not sure if they weren't there before already ... yep, old warnings.
EDIT: Real cause is the limit for the build is exceeded. Travis runs through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1055922291
Could you force-push? That will trigger another CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1057367038
Tons of "no @param for ..." warnings, and warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated. Not sure if they weren't there before already ... yep, old warnings.
EDIT: Real cause is the limit for the build is exceeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] alex-kormukhin commented on pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
alex-kormukhin commented on pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#issuecomment-1054333125
Try to fix this with https://github.com/apache/thrift/pull/2536, but may be infrastructure problem (https://github.com/johnrengelman/shadow/issues/221).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] alex-kormukhin commented on a change in pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods
Posted by GitBox <gi...@apache.org>.
alex-kormukhin commented on a change in pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#discussion_r815183851
##########
File path: test/VoidMethExceptionsTest.thrift
##########
@@ -0,0 +1,13 @@
+namespace java thrift.test.voidmethexceptions
+
+exception TExampleException {
+ 1: required string message;
+}
+
+service TAppService01 {
+ string returnString(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+ void returnVoidThrows(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+ void returnVoidNoThrowsRuntimeException(1: string msg, 2: bool throwException);
+ void returnVoidNoThrowsTApplicationException(1: string msg, 2: bool throwException);
+ oneway void onewayVoidNoThrows(1: string msg, 2: bool throwException);
Review comment:
Yes, test checks exactly that (no client-side exceptions when server throws, no client-side wait when server hangs). Method name reflects correct signature for such methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org