You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 15:28:08 UTC

[PR] test: cover 404 assets and exact payload assertions in AlertRuleAssetController [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3419:
URL: https://github.com/apache/rocketmq-dashboard/pull/3419

   ### Summary
   
   `AlertRuleAssetController` lists bundled alert-rule YAML assets, returns their raw content and exports them as attachments. The suite verified the happy paths but not unknown names or the exact response payloads.
   
   ### Changes
   
   - An unknown asset returns a `404` envelope for both the raw-YAML and export endpoints
   - List assertions now cover `group`, `ruleCount` and severity tags on every row
   - `getAsset` asserts the exact YAML payload and the export asserts its exact bytes as the response body
   
   ### Testing
   
   `mvn test -Dtest=AlertRuleAssetControllerTest` passes: 4 tests, 0 failures (up from 3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: cover 404 assets and exact payload assertions in AlertRuleAssetController [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3419: test: cover 404 assets and exact payload assertions in AlertRuleAssetController
URL: https://github.com/apache/rocketmq-dashboard/pull/3419


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org