You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2015/05/20 21:07:04 UTC
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/559
[STORM-831] Adding jira and central logging links to UI
To main UI page
- Add link to create JIRA page
- Optional link to central logging
Both links can be configured to custom service desk link.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm storm831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/559.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #559
----
commit 5ba0e62a51bb73ed99c041c336f3877970513dae
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-05-20T18:52:30Z
Adding jira and central logging links to UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-105618678
@kishorvpatil Are you sure the two binary images are in the public domain and that we would be allowed to include them in an Apache release? Is there an associated license somewhere?
Also, I'd rather have the references to JIRA be more generic, for example "UI_PROJECT_BUGTRACKER_URL" instead of "UI_PROJECT_JIRA_URL".
It would also help to add some documentation on how to set the links up. It's obvious to me, but it may not be to a new Storm user.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156566901
+1
I think the copyright line should read:
```
Copyright (c) 2015 Github, Inc.
```
But that can be done at merge time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-155916435
@kishorvpatil could you rebase? I really would like to get this into 0.11.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-105606041
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156168075
@revans2 @ptgoetz Sorry for the delay in fixing this.
- I updated config name to `UI_PROJECT_BUGTRACKER_URL`.
- The new images are from public domain.
- rebased the branch.
- New screenshot image.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-106066678
@ptgoetz Thank you for the feedback. I will rename the config o `UI_PROJECT_BUGTRACKER_URL`. Find licensed images and add documentation to the this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156168821
I am +1
@ptgoetz do you have any concerns still?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156562230
@ptgoetz and @revans2
Added MIT license to both LICENSE files. Thanks again for reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156167438
<img width="1434" alt="bugtracker-screen" src="https://cloud.githubusercontent.com/assets/6090397/11124983/22c5ab24-892d-11e5-8361-fe037943b23c.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/559#issuecomment-156217844
The bug icon is licensed free for commercial use, so that should be fine.
The statistics icon is MIT licensed by Github, Inc., so we should have an entry in LICENSE for it.
Once that's done I'm +1. I'm also fine if the LICENSE entry is added at merge time. As long as it gets done.
Also note that we have two LICENSE files, one for source releases, and one for binary releases. Both should be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---