You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/02/09 09:13:43 UTC
Review Request 30789: HIVE-9619 Uninitialized read of numBitVectors in
NumDistinctValueEstimator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30789/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-9619
https://issues.apache.org/jira/browse/HIVE-9619
Repository: hive-git
Description
-------
HIVE-9619 Uninitialized read of numBitVectors in NumDistinctValueEstimator
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java 2817044039928f9ce94d542a0a6e32970b7d082c
Diff: https://reviews.apache.org/r/30789/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 30789: HIVE-9619 Uninitialized read of
numBitVectors in NumDistinctValueEstimator
Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30789/#review72465
-----------------------------------------------------------
Ship it!
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java
<https://reviews.apache.org/r/30789/#comment118534>
Slight behaviour change, but mod 2 == 1 vs mod 2 != 0 matters only for -ve numbers.
But that is already taken care of in generateHash.
- Gopal V
On Feb. 11, 2015, 9:11 p.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30789/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 9:11 p.m.)
>
>
> Review request for hive, Gopal V and Jason Dere.
>
>
> Bugs: HIVE-9619
> https://issues.apache.org/jira/browse/HIVE-9619
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9619 Uninitialized read of numBitVectors in NumDistinctValueEstimator
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java 2817044039928f9ce94d542a0a6e32970b7d082c
>
> Diff: https://reviews.apache.org/r/30789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 30789: HIVE-9619 Uninitialized read of
numBitVectors in NumDistinctValueEstimator
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30789/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 9:11 p.m.)
Review request for hive, Gopal V and Jason Dere.
Changes
-------
make a,b,aValue and bValue final
Bugs: HIVE-9619
https://issues.apache.org/jira/browse/HIVE-9619
Repository: hive-git
Description
-------
HIVE-9619 Uninitialized read of numBitVectors in NumDistinctValueEstimator
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java 2817044039928f9ce94d542a0a6e32970b7d082c
Diff: https://reviews.apache.org/r/30789/diff/
Testing
-------
Thanks,
Alexander Pivovarov