You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/12 19:33:14 UTC
[GitHub] [pulsar] merlimat commented on a change in pull request #4036: Fix
bugs which now make cassandra integration tests pass
merlimat commented on a change in pull request #4036: Fix bugs which now make cassandra integration tests pass
URL: https://github.com/apache/pulsar/pull/4036#discussion_r275037420
##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/CassandraSinkTester.java
##########
@@ -60,7 +60,7 @@ public static CassandraSinkTester createTester(boolean builtin) {
private Session session;
private CassandraSinkTester() {
- super(NAME, "/pulsar/connectors/pulsar-io-cassandra-2.2.0-incubating-SNAPSHOT.nar", "org.apache.pulsar.io.cassandra.CassandraStringSink");
+ super(NAME, "/pulsar/connectors/pulsar-io-cassandra-2.4.0-SNAPSHOT.nar", "org.apache.pulsar.io.cassandra.CassandraStringSink");
Review comment:
We should construct this string with the current version, with `PulsarVersion.getVersion()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services