You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/06/03 14:02:55 UTC

[GitHub] [ignite] rkondakov opened a new pull request #7895: IGNITE-13070 SQL regressions detection framework

rkondakov opened a new pull request #7895:
URL: https://github.com/apache/ignite/pull/7895


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [x] There is a single JIRA ticket related to the pull request. 
   - [x] The web-link to the pull request is attached to the JIRA ticket.
   - [x] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-12407: Add Cluster API support to Java thin client`
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] AMashenkov commented on a change in pull request #7895: IGNITE-13070 SQL regressions detection framework

Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7895:
URL: https://github.com/apache/ignite/pull/7895#discussion_r437240856



##########
File path: modules/compatibility/src/test/java/org/apache/ignite/compatibility/sql/util/QueryExecutionTimer.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.ignite.compatibility.sql.util;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.function.Supplier;
+
+/**
+ * Query runner. Runs query and checks it's execution time.
+ */
+public class QueryExecutionTimer implements Supplier<Long> {
+    /** */
+    private final String qry;
+
+    /** */
+    private final SimpleConnectionPool connPool;
+
+    /** */
+    public QueryExecutionTimer(String qry, SimpleConnectionPool connPool) {
+        this.qry = qry;
+        this.connPool = connPool;
+    }
+
+    /** {@inheritDoc} */
+    @Override public Long get() {
+        long start = System.currentTimeMillis();
+
+        Connection conn = connPool.getConnection();

Review comment:
       Do you really want to include connection initialization time?
    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] rkondakov commented on a change in pull request #7895: IGNITE-13070 SQL regressions detection framework

Posted by GitBox <gi...@apache.org>.
rkondakov commented on a change in pull request #7895:
URL: https://github.com/apache/ignite/pull/7895#discussion_r437258969



##########
File path: modules/compatibility/src/test/java/org/apache/ignite/compatibility/sql/util/QueryExecutionTimer.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.ignite.compatibility.sql.util;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.function.Supplier;
+
+/**
+ * Query runner. Runs query and checks it's execution time.
+ */
+public class QueryExecutionTimer implements Supplier<Long> {
+    /** */
+    private final String qry;
+
+    /** */
+    private final SimpleConnectionPool connPool;
+
+    /** */
+    public QueryExecutionTimer(String qry, SimpleConnectionPool connPool) {
+        this.qry = qry;
+        this.connPool = connPool;
+    }
+
+    /** {@inheritDoc} */
+    @Override public Long get() {
+        long start = System.currentTimeMillis();
+
+        Connection conn = connPool.getConnection();

Review comment:
       I think it can help us to find problems not only in the plan or execution engine, but also in the connection layer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org