You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/03/14 10:46:23 UTC
[GitHub] [arrow] raulcd opened a new pull request, #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
raulcd opened a new pull request, #34557:
URL: https://github.com/apache/arrow/pull/34557
### Rationale for this change
If a committer has their ASF role on GitHub as private the GitHub PR bot author_association is not correctly assigned.
### What changes are included in this PR?
This change uses the committers list on the arrow_site repository to retrieve the list of committers.
### Are these changes tested?
There is a unit test and have tested the different steps of the workflow individually but haven't tested the full workflow.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34557:
URL: https://github.com/apache/arrow/pull/34557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34557:
URL: https://github.com/apache/arrow/pull/34557#discussion_r1135560165
##########
.github/workflows/pr_bot.yml:
##########
@@ -90,8 +96,10 @@ jobs:
archery trigger-bot \
--event-name "pull_request_review" \
--event-payload "${{ steps.extract.outputs.pr_review_path }}"
Review Comment:
```suggestion
--event-payload "${{ steps.extract.outputs.pr_review_path }}" \
```
##########
.github/workflows/pr_bot.yml:
##########
@@ -90,8 +96,10 @@ jobs:
archery trigger-bot \
--event-name "pull_request_review" \
--event-payload "${{ steps.extract.outputs.pr_review_path }}"
+ --committers "${{ steps.committers.outputs.committers_path }}"
else
archery trigger-bot \
--event-name "${{ github.event_name }}" \
--event-payload "${{ github.event_path }}"
Review Comment:
```suggestion
--event-payload "${{ github.event_path }}" \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34557:
URL: https://github.com/apache/arrow/pull/34557#issuecomment-1467855333
* Closes: #34381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34557:
URL: https://github.com/apache/arrow/pull/34557#issuecomment-1471318514
Benchmark runs are scheduled for baseline = 6ba2255c83d4813ee75e710d879ef8ff8f7c7539 and contender = fe88d9ad5c346786842913c8d2a369db099b5406. fe88d9ad5c346786842913c8d2a369db099b5406 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b6cb706f8ac845c5b2c69f8e2d18d2f8...3ba17652f4cc4d938983effe7a7034bd/)
[Finished :arrow_down:0.39% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a39df09174644c8aa0ed6cafa1a9d97c...f4098b43b2834a619ea53466e0c54de2/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fef6f6fc7d804aeaa11bbe242b25a2ee...875a157a023d4114926a2710847c8f2c/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bb8b48aef1df4519ac3ec989be747771...fd3662d05dcc457fbcada269829ada7a/)
Buildkite builds:
[Finished] [`fe88d9ad` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2530)
[Finished] [`fe88d9ad` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2560)
[Finished] [`fe88d9ad` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2528)
[Finished] [`fe88d9ad` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2551)
[Finished] [`6ba2255c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2529)
[Finished] [`6ba2255c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2559)
[Finished] [`6ba2255c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2527)
[Finished] [`6ba2255c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2550)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #34557:
URL: https://github.com/apache/arrow/pull/34557#discussion_r1135568761
##########
.github/workflows/pr_bot.yml:
##########
@@ -90,8 +96,10 @@ jobs:
archery trigger-bot \
--event-name "pull_request_review" \
--event-payload "${{ steps.extract.outputs.pr_review_path }}"
+ --committers "${{ steps.committers.outputs.committers_path }}"
else
archery trigger-bot \
--event-name "${{ github.event_name }}" \
--event-payload "${{ github.event_path }}"
Review Comment:
thanks @kou :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #34557:
URL: https://github.com/apache/arrow/pull/34557#issuecomment-1469895129
> How to confirm whether the change works or not? Should we merge this into the main for it?
I have confirmed the change works on a similar scenario:
I've created an arrow-copy-repo on an organisation. I have created a fork for my user which has a private association with the org and created a PR. The user (raulcd) even though has a private association is now treated as committer, because I am part of the committer list.
Example here: https://github.com/te-chie-la/arrow-pr-workflow-copy/pull/36
As you can see I had to tweak based on the tests as there was something wrong on reading the file but now it has been fully tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34557:
URL: https://github.com/apache/arrow/pull/34557#issuecomment-1471321067
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fef6f6fc7d804aeaa11bbe242b25a2ee...875a157a023d4114926a2710847c8f2c/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34557: GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34557:
URL: https://github.com/apache/arrow/pull/34557#issuecomment-1469026058
How to confirm whether the change works or not?
Should we merge this into the main for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org