[GitHub] [hudi] alexeykudinkin commented on a change in pull request #4060: [HUDI-2814] Addressing issues w/ Z-order Layout Optimization

[GitBox <gi...@apache.org>]

alexeykudinkin commented on a change in pull request #4060:
URL: https://github.com/apache/hudi/pull/4060#discussion_r757059123



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -245,14 +246,17 @@ private synchronized FileSystemViewManager getViewManager() {
   public abstract HoodieWriteMetadata<O> insertOverwriteTable(HoodieEngineContext context, String instantTime, I records);
 
   /**
-   * update statistics info for current table.
-   * to do adaptation, once RFC-27 is finished.
+   * Updates Metadata Indexes (like Z-Index)
+   * TODO rebase onto metadata table (post RFC-27)
    *
-   * @param context HoodieEngineContext
-   * @param instantTime Instant time for the replace action
-   * @param isOptimizeOperation whether current operation is OPTIMIZE type
-   */
-  public abstract void updateStatistics(HoodieEngineContext context, List<HoodieWriteStat> stats, String instantTime, Boolean isOptimizeOperation);
+   * @param context instance of {@link HoodieEngineContext}
+   * @param instantTime instant of the carried operation triggering the update
+   */
+  public abstract void updateMetadataIndexes(

Review comment:
       This method actually calls into `updateColumnStats` in #4106. Will inline it there




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org