[jira] [Commented] (DRILL-1505) Updating Session Value Doesn't Reflect In 'sys.options' Query Output

["Aditya Kishore (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163384#comment-14163384 ] 

Aditya Kishore commented on DRILL-1505:
---------------------------------------

The fix sets user session's OptionManager instead of DrillBit context OptionManager as FragmentContext's parent option manager. This should also fix where session options would fail to override certain behavior, e.g. setting "exec.errors.verbose".
{code}
@@ -103,7 +102,7 @@ public class FragmentContext implements Closeable {
       } else {
         list = dbContext.getConfig().getMapper().readValue(fragment.getOptionsJson(), OptionList.class);
       }
-      this.fragmentOptions = new FragmentOptionManager(context.getOptionManager(), list);
+      this.fragmentOptions = new FragmentOptionManager(connection.getSession().getOptions(), list);
     } catch (Exception e) {
       throw new ExecutionSetupException("Failure while reading plan options.", e);
     }
{code}

[~jaltekruse], can you please take a look?

> Updating Session Value Doesn't Reflect In 'sys.options' Query Output
> --------------------------------------------------------------------
>
>                 Key: DRILL-1505
>                 URL: https://issues.apache.org/jira/browse/DRILL-1505
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 0.5.0
>            Reporter: MUFEED USMAN
>            Assignee: Aditya Kishore
>            Priority: Critical
>         Attachments: DRILL-1505-Updating-Session-Value-Doesn-t-Reflect-In.patch
>
>
> Even after updating the value for a session option, the value when queried reflects the default value. How to know what is the value for the current session?
> [root@n69 bin]# ./sqlline -u jdbc:drill:zk=n69:5181,n72:5181,n73:5181 -n admin -p admin
> sqlline version 1.1.6
> 0: jdbc:drill:zk=n69:5181,n72:5181,n73:5181> alter session set `exec.errors.verbose`=true;
> +------------+------------+
> |     ok     |  summary   |
> +------------+------------+
> | true       | exec.errors.verbose updated. |
> +------------+------------+
> 1 row selected (0.185 seconds)
> 0: jdbc:drill:zk=n69:5181,n72:5181,n73:5181> select * from sys.options where name = 'exec.errors.verbose';
> +------------+------------+------------+------------+------------+------------+------------+
> |    name    |    kind    |    type    |  num_val   | string_val |  bool_val  | float_val  |
> +------------+------------+------------+------------+------------+------------+------------+
> | exec.errors.verbose | BOOLEAN    | SYSTEM     | null       | null       | false      | null       |
> +------------+------------+------------+------------+------------+------------+------------+
> 1 row selected (0.192 seconds)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)