You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/11/01 20:53:55 UTC

[impala] branch master updated (28b1d53 -> 770e72d)

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git.


    from 28b1d53  IMPALA-9108: exclude leveldbjni mvn dependency
     new 49a31ae  IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
     new 770e72d  IMPALA-9105: Catalog debug page top-n table has a URL generation issue

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 docs/topics/impala_auditing.xml | 46 +++++++++++++++++------------------------
 www/catalog.tmpl                |  7 ++++---
 2 files changed, 23 insertions(+), 30 deletions(-)


[impala] 02/02: IMPALA-9105: Catalog debug page top-n table has a URL generation issue

Posted by ta...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 770e72d53e11c2902be848a5f2608c4b4c6e19aa
Author: Jiawei Wang <ji...@cloudera.com>
AuthorDate: Wed Oct 30 13:32:58 2019 -0500

    IMPALA-9105: Catalog debug page top-n table has a URL generation issue
    
    What's the problem:
    Previously, catalogd debug page does not have 'fqtn' property. Because
    CatalogServer::GetCatalogUsage() does not pass fqtn to the template.
    Thus, the generated page table detail page cannot be opened. Also,
    Someone might accedentially deleted <td> which makes the catalogd UI
    top-K page unorganized.
    
    Fix:
    Correct the URL generation part.
    
    Test:
    Open the page and all the tables object can be correctly opened.
    
    Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
    Reviewed-on: http://gerrit.cloudera.org:8080/14589
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 www/catalog.tmpl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/www/catalog.tmpl b/www/catalog.tmpl
index 126c658..095717a 100644
--- a/www/catalog.tmpl
+++ b/www/catalog.tmpl
@@ -39,11 +39,12 @@ under the License.
       <tbody>
         {{#large_tables}}
         <tr>
+          <td>
           <!-- The /catalog_object endpoint is disabled if local_catalog_mode is used
             since metadata is partially fetched on demand. -->
           {{?use_local_catalog}} {{name}} {{/use_local_catalog}}
           {{^use_local_catalog}}
-           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
           {{/use_local_catalog}}
           </td>
           <td>{{mem_estimate}}</td>
@@ -88,7 +89,7 @@ under the License.
           <td>
           {{?use_local_catalog}} {{name}} {{/use_local_catalog}}
           {{^use_local_catalog}}
-           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
           {{/use_local_catalog}}
           </td>
           <td>{{num_metadata_ops}}</td>
@@ -132,7 +133,7 @@ under the License.
           <td>
           {{?use_local_catalog}} {{name}} {{/use_local_catalog}}
           {{^use_local_catalog}}
-           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+           <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
           {{/use_local_catalog}}
           </td>
           <td>{{num_files}}</td>


[impala] 01/02: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log

Posted by ta...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 49a31aef0b71e94cbbea412a4071721b3b5f5359
Author: Alex Rodoni <ar...@cloudera.com>
AuthorDate: Tue Oct 29 14:40:56 2019 -0700

    IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
    
    Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c
    Reviewed-on: http://gerrit.cloudera.org:8080/14575
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
 docs/topics/impala_auditing.xml | 46 +++++++++++++++++------------------------
 1 file changed, 19 insertions(+), 27 deletions(-)

diff --git a/docs/topics/impala_auditing.xml b/docs/topics/impala_auditing.xml
index 87307c0..8183cce 100644
--- a/docs/topics/impala_auditing.xml
+++ b/docs/topics/impala_auditing.xml
@@ -258,37 +258,29 @@ Here is an excerpt from a sample audit log file:
 
     <conbody>
 
-      <p>
-        The kinds of SQL queries represented in the audit log are:
-      </p>
+      <p> The following types of SQL operations are recorded in the audit
+        log:</p>
 
       <ul>
-        <li>
-          Queries that are prevented due to lack of authorization.
-        </li>
-
-        <li>
-          Queries that Impala can analyze and parse to determine that they are authorized. The
-          audit data is recorded immediately after Impala finishes its analysis, before the
-          query is actually executed.
-        </li>
+        <li> Queries that are prevented due to lack of authorization. </li>
+        <li> Queries that Impala can analyze and parse to determine that they
+          are authorized. The audit data is recorded immediately after Impala
+          finishes its analysis, before the query is actually executed. </li>
+        <li> Queries whose results are available to be fetched by clients.</li>
+        <li>Finished DDL operations.</li>
       </ul>
 
-      <p>
-        The audit log does not contain entries for queries that could not be parsed and
-        analyzed. For example, a query that fails due to a syntax error is not recorded in the
-        audit log. The audit log also does not contain queries that fail due to a reference to a
-        table that does not exist, if you would be authorized to access the table if it did
-        exist.
-      </p>
-
-      <p>
-        Certain statements in the <cmdname>impala-shell</cmdname> interpreter, such as
-        <codeph>CONNECT</codeph>, <codeph rev="1.4.0">SUMMARY</codeph>,
-        <codeph>PROFILE</codeph>, <codeph>SET</codeph>, and <codeph>QUIT</codeph>, do not
-        correspond to actual SQL queries, and these statements are not reflected in the audit
-        log.
-      </p>
+      <p> The audit log does not contain entries for queries that could not be
+        parsed and analyzed. For example, a query that fails due to a syntax
+        error is not recorded in the audit log. </p>
+      <p>The audit log does not contain queries that fail due to a reference to
+        a table that does not exist. </p>
+
+      <p> Certain statements in the <cmdname>impala-shell</cmdname> interpreter,
+        such as <codeph>CONNECT</codeph>, <codeph rev="1.4.0">SUMMARY</codeph>,
+          <codeph>PROFILE</codeph>, <codeph>SET</codeph>, and
+          <codeph>QUIT</codeph>, do not correspond to actual SQL queries, and
+        these statements are not recorded in the audit log. </p>
 
     </conbody>