[GitHub] godfreyhe commented on a change in pull request #7817: [FLINK-11702][table-planner-blink] Introduce a new table type system: InternalType

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #7817: [FLINK-11702][table-planner-blink] Introduce a new table type system: InternalType
URL: https://github.com/apache/flink/pull/7817#discussion_r260621495
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/type/DecimalType.java
 ##########
 @@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.type;
+
+import java.math.BigDecimal;
+
+import static java.lang.String.format;
+
+/**
+ * Decimal type.
+ */
+public class DecimalType implements AtomicType {
+
+	public static final int MAX_PRECISION = 38;
+
+	public static final int MAX_SCALE = 18;
+
+	private final int precision;
+	private final int scale;
+
+	// Default to be same with Integer.
+	public static final DecimalType USER_DEFAULT = new DecimalType(10, 0);
+
+	// Mainly used for implicitly type cast and test.
+	public static final DecimalType SYSTEM_DEFAULT = new DecimalType(MAX_PRECISION, MAX_SCALE);
+
+	public DecimalType(int precision, int scale) {
+
+		if (scale > precision) {
+			throw new IllegalArgumentException(format("Decimal scale (%s) cannot be greater than " +
+					"precision (%s).", scale, precision));
+		}
+
+		if (precision > DecimalType.MAX_PRECISION) {
+			throw new IllegalArgumentException("DecimalType can only support precision up to 38");
+		}
+
+		this.precision = precision;
+		this.scale = scale;
+	}
+
+	public int precision(){
+		return this.precision;
+	}
+
+	public int scale(){
+		return this.scale;
+	}
+
+	public static DecimalType of(int precision, int scale) {
+		return new DecimalType(precision, scale);
+	}
+
+	public static DecimalType of(BigDecimal value) {
+		return of(value.precision(), value.scale());
+	}
+
+	/**
+	 * Create a DecimalType instance from its qualified name in the form of "decimal(p,s)".
+	 * @param qualifiedName qualified decimal type name
+	 * @return a DecimalType instance
+	 */
+	public static DecimalType of(String qualifiedName) {
+		if (!qualifiedName.startsWith("decimal(")) {
+			throw new IllegalArgumentException("Illegal form of qualified decimal type " + qualifiedName);
+		}
+
+		int start = qualifiedName.indexOf('(');
+		int end = qualifiedName.indexOf(')');
+		String ps = qualifiedName.substring(start + 1, end);
+		String[] sArray = ps.split(",");
+		if (sArray.length != 2) {
+			throw new IllegalArgumentException("Illegal form of qualified decimal type " + qualifiedName);
+		}
+
+		int precision = Integer.parseInt(sArray[0]);
+		int scale = Integer.parseInt(sArray[1]);
 
 Review comment:
   should handle blank char in qualifiedName, otherwise NumberFormatException may be thrown. e.g. decimal(10, 1)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services