You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/06 14:23:16 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #122: WIP initial psycopg plugin

kezhenxu94 commented on pull request #122:
URL: https://github.com/apache/skywalking-python/pull/122#issuecomment-855407509


   > And another idea unrelated to which option above is taken. If you are not locked into the current options scheme - reduce the two parameters `config.mysql_trace_sql_parameters` and `config.mysql_sql_parameters_max_length` into a single option `config.mysql_parameters` (or something like that) which gives the length and if length 0 is specified (default) then disables parameters?
   
   This is an optimization I've been thinking about, I'm +1 to it.
   
   Also, I prefer (2.), since there is rare situation that a service will use multiple DB layers and not use the same configurations for them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org