You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/07 18:27:22 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
nvazquez opened a new pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414
### Description
This PR uses the host name if the host IP is not found on Vmware for Vmware 7 console proxy websocket URL
Fixes: #5413
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914526727
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914738896
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914931025
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914931296
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#discussion_r704062615
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -1177,14 +1178,23 @@ public boolean configureVm(Ternary<VirtualDevice, VirtualDeviceConfigSpecOperati
return false;
}
+ private String getHostFqdn(HostMO hostMO, String hostName) {
Review comment:
@nvazquez I think, it is better to keep this method in HostMO.
```
public String getHostFqdn() {
try {
HostDnsConfig hostDnsConfig = getHostNetworkInfo().getDnsConfig();
return String.format("%s.%s", hostDnsConfig.getHostName(), hostDnsConfig.getDomainName());
} catch (Exception e) {
s_logger.error("Could not get host FQDN for host: " + getHostName());
}
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914762619
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-915210996
I'm closing this in favour of #5419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914526329
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914931428
@blueorangutan test centos7 vmware-70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-915431894
<b>Trillian test result (tid-1988)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39607 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5414-t1988-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914932381
@rhtyd unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914544290
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#issuecomment-914738263
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org