[GitHub] michellethomas commented on a change in pull request #5274: [get_df] Fix datetime conversion

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #5274: [get_df] Fix datetime conversion
URL: https://github.com/apache/incubator-superset/pull/5274#discussion_r198325150
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -197,13 +197,11 @@ def get_df(self, query_obj=None):
         # be considered as the default ISO date format
         # If the datetime format is unix, the parse will use the corresponding
         # parsing logic.
-        if df is None or df.empty:
-            return pd.DataFrame()
-        else:
+        if not df.empty:
 
 Review comment:
   You removed the check for `df is None` does that mean df won't be None? Will we still be passing an empty data frame if there's no data?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org