[jira] [Commented] (KAFKA-6029) Controller should wait for the leader migration to finish before ack a ControlledShutdownRequest

["Colin P. McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840876#comment-16840876 ] 

Colin P. McCabe commented on KAFKA-6029:
----------------------------------------

This sounds like a good improvement.  I can take the JIRA, if nobody else is working on it.

> Controller should wait for the leader migration to finish before ack a ControlledShutdownRequest
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6029
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6029
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: controller, core
>    Affects Versions: 1.0.0
>            Reporter: Jiangjie Qin
>            Assignee: Zhanxiang (Patrick) Huang
>            Priority: Major
>
> In the controlled shutdown process, the controller will return the ControlledShutdownResponse immediately after the state machine is updated. Because the LeaderAndIsrRequests and UpdateMetadataRequests may not have been successfully processed by the brokers, the leader migration and active ISR shrink may not have done when the shutting down broker proceeds to shut down. This will cause some of the leaders to take up to replica.lag.time.max.ms to kick the broker out of ISR. Meanwhile the produce purgatory size will grow.
> Ideally, the controller should wait until all the LeaderAndIsrRequests and UpdateMetadataRequests has been acked before sending back the ControlledShutdownResponse.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)