[GitHub] [ozone] fapifta commented on pull request #2814: HDDS-5891. OFS mkdir -p does not work as expected for bucket creation when volume exists due to volume create ACL check

[GitBox <gi...@apache.org>]

fapifta commented on pull request #2814:
URL: https://github.com/apache/ozone/pull/2814#issuecomment-963367938


   Hi @smengcl,
   thank you for working on this forward.
   
   Please help me understand what is the aim here, as I am not sure why are we doing the getBucket call this way. In my head, the algorithm is simply this:
   - get the volume from the objectStore
   - if volume exists get the bucket from the volume
   - if volume does not exist, and if we should create it create it
   - if the bucket does not exist create it
   
   This is better reflected by #2815, the one @dombizita created, based on our earlier discussions with her.
   
   I would like to understand why we are using the ObjectStore's client proxy to directly do OzoneManager protocol calls, when we can get the volume, and from the volume we can get the bucket later on, is there a good reason to turn to the underlying API I don't see, or we can even get rid of using the OzoneManager protocol proxy directly?
   
   On the other hand, I pretty much agree that the BucketManager#getBucketInfo(volName, bucketName) method should throw a VOLUME_NOT_FOUND in case the volume does not exist, that is a much clearer cause in this case.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org