You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@storm.apache.org by Srividhya Shanmugam <Sr...@fico.com> on 2015/06/02 22:45:17 UTC

Applying a patch

I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

question regarding how to upgrade storm without downtime

Posted by 이승진 <sw...@navercorp.com>.
We have several topologies that should run continuously without halting.
 
1. how to release next version of topology without halting?
 
In some cases, we can run two same topologies in a cluster so that when running next version of topology jar, we can restart one by one not to halt entire service.
 
But if we cannot seperate incoming spout, this strategy cannot be applied also.
 
2. main question, how to upgrade storm without downtime?
 
Currently when we upgrade storm, we stop all the topologies then kill supervisors, nimbus, and launch new nimbus, supervisor, then run topologies again.
 
Is there any way to avoid this?
 
Maybe relaunching supervisor one by one and finally replacing nimbus would work without killing running topology, but I'm not sure about that.
 
do you have any idea?

RE: Applying a patch

Posted by Srividhya Shanmugam <Sr...@fico.com>.
When I tried to clone the tag v0.9.3, its actually 0.9.5-snapshot. So I downloaded the 0.9.3 source, manually applied the change, built and deployed.

But now that 0.9.5 is out…..we should be using 0.9.5 rather than the patch. Thanks for all the help.

From: Srividhya Shanmugam [mailto:SrividhyaShanmugam@fico.com]
Sent: Tuesday, June 02, 2015 11:36 PM
To: user@storm.apache.org
Subject: RE: Applying a patch

Thanks …I will try what you have suggested.

From: 임정택 [mailto:kabhwan@gmail.com]
Sent: Tuesday, June 02, 2015 10:11 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

"git apply 527.patch" would work.
But since 527's base is not v0.9.3, it could have conflicts, and now git complains, "path does not apply".
(Maybe line numbers have been changed.)

So if you don't mind, I'd like you to copy & paste changeset (it's just 4 lines) into your local workspace and build.
https://github.com/apache/storm/pull/527/files

After then you can create "patch" based on 0.9.3 if you want.


2015-06-03 9:56 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Since 0.9.5 is not GA yet,  we would try applying the patch on 0.9.3. I tried cloning 0.9.3 branch and applied patch in my local workspace.

I was able to download the patch. But when I tried applying patch 527.patch, I got “fatal: unrecognized input”. I am using a GitBash (Windows) to issue these commands. Any suggestion on why applying patch fails?

The command I used was “apply patch 527.patch”

From: 임정택 [mailto:kabhwan@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 5:41 PM

To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

I think there would be no problem applying this patch to 0.9.2 and upper, since mk-transfer-fn has changed to current via 0.9.2.
But Storm 0.9.5 also resolves some more puzzling errors so I recommend you to apply 0.9.5.

Thanks!
Jungtaek Lim (HeartSaVioR)



2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Thank you. Upgrading to a higher version requires testing almost all the functionalities towards the end of a release.

Do you think there will be problem of applying this patch towards a previous version such as 0.9.3?

From: P. Taylor Goetz [mailto:ptgoetz@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 4:54 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com>> wrote:

I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.


This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

RE: Applying a patch

Posted by Srividhya Shanmugam <Sr...@fico.com>.
I cloned from tag v0.9.3 and I already see this change merged in to worker.clj


(let [remote (.get remoteMap task)]
                      (if (not-nil? task)
                        (.add remote (TaskMessage. task (.serialize serializer tuple)))
                        (log-warn "Can't transfer tuple - task value is nil. tuple type: " (pr-str (type tuple)) " and information: " (pr-str tuple)))
                     ))))

Looks like I just have to build from the tag(v0.9.3), package distribution and deploy. I will update with results.
Thanks.

From: Srividhya Shanmugam [mailto:SrividhyaShanmugam@fico.com]
Sent: Tuesday, June 02, 2015 11:36 PM
To: user@storm.apache.org
Subject: RE: Applying a patch

Thanks …I will try what you have suggested.

From: 임정택 [mailto:kabhwan@gmail.com]
Sent: Tuesday, June 02, 2015 10:11 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

"git apply 527.patch" would work.
But since 527's base is not v0.9.3, it could have conflicts, and now git complains, "path does not apply".
(Maybe line numbers have been changed.)

So if you don't mind, I'd like you to copy & paste changeset (it's just 4 lines) into your local workspace and build.
https://github.com/apache/storm/pull/527/files

After then you can create "patch" based on 0.9.3 if you want.


2015-06-03 9:56 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Since 0.9.5 is not GA yet,  we would try applying the patch on 0.9.3. I tried cloning 0.9.3 branch and applied patch in my local workspace.

I was able to download the patch. But when I tried applying patch 527.patch, I got “fatal: unrecognized input”. I am using a GitBash (Windows) to issue these commands. Any suggestion on why applying patch fails?

The command I used was “apply patch 527.patch”

From: 임정택 [mailto:kabhwan@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 5:41 PM

To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

I think there would be no problem applying this patch to 0.9.2 and upper, since mk-transfer-fn has changed to current via 0.9.2.
But Storm 0.9.5 also resolves some more puzzling errors so I recommend you to apply 0.9.5.

Thanks!
Jungtaek Lim (HeartSaVioR)



2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Thank you. Upgrading to a higher version requires testing almost all the functionalities towards the end of a release.

Do you think there will be problem of applying this patch towards a previous version such as 0.9.3?

From: P. Taylor Goetz [mailto:ptgoetz@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 4:54 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com>> wrote:

I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.


This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

RE: Applying a patch

Posted by Srividhya Shanmugam <Sr...@fico.com>.
Thanks …I will try what you have suggested.

From: 임정택 [mailto:kabhwan@gmail.com]
Sent: Tuesday, June 02, 2015 10:11 PM
To: user@storm.apache.org
Subject: Re: Applying a patch

"git apply 527.patch" would work.
But since 527's base is not v0.9.3, it could have conflicts, and now git complains, "path does not apply".
(Maybe line numbers have been changed.)

So if you don't mind, I'd like you to copy & paste changeset (it's just 4 lines) into your local workspace and build.
https://github.com/apache/storm/pull/527/files

After then you can create "patch" based on 0.9.3 if you want.


2015-06-03 9:56 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Since 0.9.5 is not GA yet,  we would try applying the patch on 0.9.3. I tried cloning 0.9.3 branch and applied patch in my local workspace.

I was able to download the patch. But when I tried applying patch 527.patch, I got “fatal: unrecognized input”. I am using a GitBash (Windows) to issue these commands. Any suggestion on why applying patch fails?

The command I used was “apply patch 527.patch”

From: 임정택 [mailto:kabhwan@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 5:41 PM

To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

I think there would be no problem applying this patch to 0.9.2 and upper, since mk-transfer-fn has changed to current via 0.9.2.
But Storm 0.9.5 also resolves some more puzzling errors so I recommend you to apply 0.9.5.

Thanks!
Jungtaek Lim (HeartSaVioR)



2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Thank you. Upgrading to a higher version requires testing almost all the functionalities towards the end of a release.

Do you think there will be problem of applying this patch towards a previous version such as 0.9.3?

From: P. Taylor Goetz [mailto:ptgoetz@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 4:54 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com>> wrote:

I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.


This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

Re: Applying a patch

Posted by 임정택 <ka...@gmail.com>.
"git apply 527.patch" would work.
But since 527's base is not v0.9.3, it could have conflicts, and now git
complains, "path does not apply".
(Maybe line numbers have been changed.)

So if you don't mind, I'd like you to copy & paste changeset (it's just 4
lines) into your local workspace and build.
https://github.com/apache/storm/pull/527/files

After then you can create "patch" based on 0.9.3 if you want.


2015-06-03 9:56 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>:

>  Since 0.9.5 is not GA yet,  we would try applying the patch on 0.9.3. I
> tried cloning 0.9.3 branch and applied patch in my local workspace.
>
>
>
> I was able to download the patch. But when I tried applying patch
> 527.patch, I got “fatal: unrecognized input”. I am using a GitBash
> (Windows) to issue these commands. Any suggestion on why applying patch
> fails?
>
>
>
> The command I used was “apply patch 527.patch”
>
>
>
> *From:* 임정택 [mailto:kabhwan@gmail.com]
> *Sent:* Tuesday, June 02, 2015 5:41 PM
>
> *To:* user@storm.apache.org
> *Subject:* Re: Applying a patch
>
>
>
> I think there would be no problem applying this patch to 0.9.2 and upper,
> since mk-transfer-fn has changed to current via 0.9.2.
>
> But Storm 0.9.5 also resolves some more puzzling errors so I recommend you
> to apply 0.9.5.
>
>
>
> Thanks!
>
> Jungtaek Lim (HeartSaVioR)
>
>
>
>
>
>
>
> 2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <SrividhyaShanmugam@fico.com
> >:
>
> Thank you. Upgrading to a higher version requires testing almost all the
> functionalities towards the end of a release.
>
>
>
> Do you think there will be problem of applying this patch towards a
> previous version such as 0.9.3?
>
>
>
> *From:* P. Taylor Goetz [mailto:ptgoetz@gmail.com]
> *Sent:* Tuesday, June 02, 2015 4:54 PM
> *To:* user@storm.apache.org
> *Subject:* Re: Applying a patch
>
>
>
> The easiest way would be to build the v0.9.5 tag from git. That version
> includes that fix, among other stability improvements and should be
> released in the next few days.
>
>
>
> -Taylor
>
>
>
>
>
> On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <
> SrividhyaShanmugam@fico.com> wrote:
>
>
>
> I am trying to apply a patch for
> https://issues.apache.org/jira/browse/STORM-790 in version of storm that
> we are currently using(0.9.3). Are there any instruction cheatsheet to
> apply a STORM patch?
>
>
>
> Thank you.
>
>
> This email and any files transmitted with it are confidential, proprietary
> and intended solely for the individual or entity to whom they are
> addressed. If you have received this email in error please delete it
> immediately.
>
>
>
>
> This email and any files transmitted with it are confidential, proprietary
> and intended solely for the individual or entity to whom they are
> addressed. If you have received this email in error please delete it
> immediately.
>
>
>
>
>
> --
>
> Name : 임 정택
> Blog : http://www.heartsavior.net / http://dev.heartsavior.net
> Twitter : http://twitter.com/heartsavior
>
> LinkedIn : http://www.linkedin.com/in/heartsavior
>
> This email and any files transmitted with it are confidential, proprietary
> and intended solely for the individual or entity to whom they are
> addressed. If you have received this email in error please delete it
> immediately.
>



-- 
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

RE: Applying a patch

Posted by Srividhya Shanmugam <Sr...@fico.com>.
Since 0.9.5 is not GA yet,  we would try applying the patch on 0.9.3. I tried cloning 0.9.3 branch and applied patch in my local workspace.

I was able to download the patch. But when I tried applying patch 527.patch, I got “fatal: unrecognized input”. I am using a GitBash (Windows) to issue these commands. Any suggestion on why applying patch fails?

The command I used was “apply patch 527.patch”

From: 임정택 [mailto:kabhwan@gmail.com]
Sent: Tuesday, June 02, 2015 5:41 PM
To: user@storm.apache.org
Subject: Re: Applying a patch

I think there would be no problem applying this patch to 0.9.2 and upper, since mk-transfer-fn has changed to current via 0.9.2.
But Storm 0.9.5 also resolves some more puzzling errors so I recommend you to apply 0.9.5.

Thanks!
Jungtaek Lim (HeartSaVioR)



2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>>:
Thank you. Upgrading to a higher version requires testing almost all the functionalities towards the end of a release.

Do you think there will be problem of applying this patch towards a previous version such as 0.9.3?

From: P. Taylor Goetz [mailto:ptgoetz@gmail.com<ma...@gmail.com>]
Sent: Tuesday, June 02, 2015 4:54 PM
To: user@storm.apache.org<ma...@storm.apache.org>
Subject: Re: Applying a patch

The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com>> wrote:

I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.


This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.



--
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

Re: Applying a patch

Posted by 임정택 <ka...@gmail.com>.
I think there would be no problem applying this patch to 0.9.2 and upper,
since mk-transfer-fn has changed to current via 0.9.2.
But Storm 0.9.5 also resolves some more puzzling errors so I recommend you
to apply 0.9.5.

Thanks!
Jungtaek Lim (HeartSaVioR)



2015-06-03 5:58 GMT+09:00 Srividhya Shanmugam <Sr...@fico.com>:

>  Thank you. Upgrading to a higher version requires testing almost all the
> functionalities towards the end of a release.
>
>
>
> Do you think there will be problem of applying this patch towards a
> previous version such as 0.9.3?
>
>
>
> *From:* P. Taylor Goetz [mailto:ptgoetz@gmail.com]
> *Sent:* Tuesday, June 02, 2015 4:54 PM
> *To:* user@storm.apache.org
> *Subject:* Re: Applying a patch
>
>
>
> The easiest way would be to build the v0.9.5 tag from git. That version
> includes that fix, among other stability improvements and should be
> released in the next few days.
>
>
>
> -Taylor
>
>
>
>
>
> On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <
> SrividhyaShanmugam@fico.com> wrote:
>
>
>
>   I am trying to apply a patch for
> https://issues.apache.org/jira/browse/STORM-790 in version of storm that
> we are currently using(0.9.3). Are there any instruction cheatsheet to
> apply a STORM patch?
>
>
>
> Thank you.
>
>
> This email and any files transmitted with it are confidential, proprietary
> and intended solely for the individual or entity to whom they are
> addressed. If you have received this email in error please delete it
> immediately.
>
>
>
> This email and any files transmitted with it are confidential, proprietary
> and intended solely for the individual or entity to whom they are
> addressed. If you have received this email in error please delete it
> immediately.
>



-- 
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

RE: Applying a patch

Posted by Srividhya Shanmugam <Sr...@fico.com>.
Thank you. Upgrading to a higher version requires testing almost all the functionalities towards the end of a release.

Do you think there will be problem of applying this patch towards a previous version such as 0.9.3?

From: P. Taylor Goetz [mailto:ptgoetz@gmail.com]
Sent: Tuesday, June 02, 2015 4:54 PM
To: user@storm.apache.org
Subject: Re: Applying a patch

The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com>> wrote:


I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?

Thank you.

This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.


This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.

Re: Applying a patch

Posted by "P. Taylor Goetz" <pt...@gmail.com>.
The easiest way would be to build the v0.9.5 tag from git. That version includes that fix, among other stability improvements and should be released in the next few days.

-Taylor


On Jun 2, 2015, at 4:45 PM, Srividhya Shanmugam <Sr...@fico.com> wrote:

> I am trying to apply a patch for https://issues.apache.org/jira/browse/STORM-790 in version of storm that we are currently using(0.9.3). Are there any instruction cheatsheet to apply a STORM patch?
>  
> Thank you.
> 
> This email and any files transmitted with it are confidential, proprietary and intended solely for the individual or entity to whom they are addressed. If you have received this email in error please delete it immediately.