You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/11 14:06:54 UTC

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4344: supprt gRPC alarm hook.

JohnNiang commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r377652539
 
 

 ##########
 File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCAlarmSetting.java
 ##########
 @@ -27,4 +28,20 @@
 public class GRPCAlarmSetting extends ModuleConfig {
     private String targetHost;
     private int targetPort;
+
+    @Override
+    public boolean equals(final Object o) {
 
 Review comment:
   `equals` and `hashCode` methods could be replaced by Lombok annotation: `@EqualsAndHashCode(callSuper = false)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services