You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/19 13:24:11 UTC

[GitHub] [pulsar-adapters] hailin0 opened a new pull request, #36: [pulsar-kafka] Fixed blockIfQueueFull config

hailin0 opened a new pull request, #36:
URL: https://github.com/apache/pulsar-adapters/pull/36

   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Fixes blockIfQueueFull config
   
   
   ### Motivation
   
   
   Fix blockIfQueueFull=true config not work
   
   ### Modifications
   
   Fix Boolean.getBoolean(value) => Boolean.parseBoolean(value);
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for blockIfQueueFull=true *
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-adapters] cbornet merged pull request #36: [pulsar-kafka] Fixed blockIfQueueFull config

Posted by "cbornet (via GitHub)" <gi...@apache.org>.
cbornet merged PR #36:
URL: https://github.com/apache/pulsar-adapters/pull/36


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-adapters] hailin0 commented on pull request #36: [pulsar-kafka] Fixed blockIfQueueFull config

Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #36:
URL: https://github.com/apache/pulsar-adapters/pull/36#issuecomment-1189053368

   @rdhabalia 
   @dlg99 
   @eolivelli 
   
   Please help to review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org