You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 22:42:05 UTC
[GitHub] [airflow] ashb opened a new pull request #14084: Speed up building provider packages by ~4 times
ashb opened a new pull request #14084:
URL: https://github.com/apache/airflow/pull/14084
These changes speeds up the build packages step from about 7mins30 to
2min10 on my laptop, and the generate documentation from 3mins to
1min30. On CI it will be even quicker
The changes are:
- Don't do a git fetch for _every_ provider. Once is enough.
- Don't shell out to black, but use the Python API. (Spawning a python
process is not free)
- As a tidy up, don't print the info about version suffix once per
package, just once is enough as it doesn't change from package to
package
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14084:
URL: https://github.com/apache/airflow/pull/14084#issuecomment-773711747
[The Workflow run](https://github.com/apache/airflow/actions/runs/538969804) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14084:
URL: https://github.com/apache/airflow/pull/14084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14084:
URL: https://github.com/apache/airflow/pull/14084#issuecomment-773663123
It's all "machine build time" that is consumed, which we're going to start "paying" for directly soon :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14084:
URL: https://github.com/apache/airflow/pull/14084#issuecomment-773670609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14084:
URL: https://github.com/apache/airflow/pull/14084#issuecomment-773663123
It's all "machine build time" that is consumed, which we're going to start "paying" for directly soon :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14084: Speed up building provider packages by ~4 times
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14084:
URL: https://github.com/apache/airflow/pull/14084#issuecomment-773670609
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org