You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:51:38 UTC

[GitHub] [incubator-yunikorn-core] kingamarton opened a new pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

kingamarton opened a new pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org

[GitHub] [incubator-yunikorn-core] yangwwei commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#issuecomment-604505127
 
 
   Hi @kingamarton 
   
   You can click the `detail` or the `checks`, expand the check and there is a rerun button on the right side corner. No worries, the failure should not be related. We've found some flaky tests on github, we will need to fix them to get a more stable action execution. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] mKinga commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
mKinga commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#discussion_r398770416
 
 

 ##########
 File path: docs/setup/deployment.md
 ##########
 @@ -56,4 +56,4 @@ kubectl port-forward ${POD} 9889 9080
 ```
 
 `9889` is the default port for Web UI, `9080` is the default port of scheduler's Restful service where web UI retrieves info from.
-Once this is done, web UI will be available at: http://localhost:9889.
\ No newline at end of file
+Once this is done, web UI will be available at: http://localhost:9889.
 
 Review comment:
   This was unintentional. I checked the two files and I introduces a newline by mistake. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#discussion_r398779580
 
 

 ##########
 File path: docs/setup/deployment.md
 ##########
 @@ -56,4 +56,4 @@ kubectl port-forward ${POD} 9889 9080
 ```
 
 `9889` is the default port for Web UI, `9080` is the default port of scheduler's Restful service where web UI retrieves info from.
-Once this is done, web UI will be available at: http://localhost:9889.
\ No newline at end of file
+Once this is done, web UI will be available at: http://localhost:9889.
 
 Review comment:
   This was unintentional. I checked the two files and I introduces a newline by mistake. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#discussion_r398744922
 
 

 ##########
 File path: docs/setup/deployment.md
 ##########
 @@ -56,4 +56,4 @@ kubectl port-forward ${POD} 9889 9080
 ```
 
 `9889` is the default port for Web UI, `9080` is the default port of scheduler's Restful service where web UI retrieves info from.
-Once this is done, web UI will be available at: http://localhost:9889.
\ No newline at end of file
+Once this is done, web UI will be available at: http://localhost:9889.
 
 Review comment:
   what has changed on this line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] yangwwei commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#issuecomment-604720613
 
 
   I guess this is good. +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] mKinga commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
mKinga commented on a change in pull request #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#discussion_r398770416
 
 

 ##########
 File path: docs/setup/deployment.md
 ##########
 @@ -56,4 +56,4 @@ kubectl port-forward ${POD} 9889 9080
 ```
 
 `9889` is the default port for Web UI, `9080` is the default port of scheduler's Restful service where web UI retrieves info from.
-Once this is done, web UI will be available at: http://localhost:9889.
\ No newline at end of file
+Once this is done, web UI will be available at: http://localhost:9889.
 
 Review comment:
   This was unintentional. I checked the two files and I introduces a newline by mistake. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-yunikorn-core] kingamarton commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md

Posted by GitBox <gi...@apache.org>.
kingamarton commented on issue #111: [YUNIKORN-56] Broken Scheduler configuration link in deployment.md
URL: https://github.com/apache/incubator-yunikorn-core/pull/111#issuecomment-604483533
 
 
   The change touches only the documentation. It should not cause unit test failures. @yangwwei can you retrigger the check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services