You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/30 13:00:52 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #870: examples/foc: replace the requested velocity input with a more general setpoint input

xiaoxiang781216 commented on a change in pull request #870:
URL: https://github.com/apache/incubator-nuttx-apps/pull/870#discussion_r739652134



##########
File path: examples/foc/foc_adc.h
##########
@@ -66,7 +66,7 @@
 #ifdef CONFIG_EXAMPLES_FOC_SETPOINT_CONST
 #  define SETPOINT_ADC_SCALE   (1)
 #  if CONFIG_EXAMPLES_FOC_SETPOINT_CONST_VALUE == 0
-#    error
+/* #    error */

Review comment:
       can we merge the patch in  nuttx first?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org