You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/18 02:07:20 UTC
[jira] [Commented] (CB-11646) coho prepare-release-branch should
auto get version from package.json instead of it being passed in.
[ https://issues.apache.org/jira/browse/CB-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425807#comment-15425807 ]
ASF GitHub Bot commented on CB-11646:
-------------------------------------
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/130#discussion_r75238878
--- Diff: src/platform-release.js ---
@@ -131,6 +140,7 @@ exports.prepareReleaseBranchCommand = function*() {
var repos = flagutil.computeReposFromFlag(argv.r);
var version = flagutil.validateVersionString(argv.version);
var branchName = getVersionBranchName(version);
+ var platform = repos[0].id;
--- End diff --
I don't think this line is needed in this commit.
> coho prepare-release-branch should auto get version from package.json instead of it being passed in.
> ----------------------------------------------------------------------------------------------------
>
> Key: CB-11646
> URL: https://issues.apache.org/jira/browse/CB-11646
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: Julia Geist
> Assignee: Julia Geist
> Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org