[GitHub] [camel-website] zregvart commented on issue #22: [CAMEL-11501] Update README

[GitBox <gi...@apache.org>]

zregvart commented on issue #22: [CAMEL-11501] Update README
URL: https://github.com/apache/camel-website/pull/22#issuecomment-471171221
 
 
   We control the version of yarn via `.yarnrc`, so no matter what version of yarn you have installed the version we have in the repository is used. See:
   
   https://github.com/apache/camel-website/blob/d98c2301320b0ebe857a0d304d33b23cbfa4966a/.yarnrc#L6
   
   https://github.com/apache/camel-website/blob/d98c2301320b0ebe857a0d304d33b23cbfa4966a/antora-ui-camel/.yarnrc#L6
   
   I would like not to have another build tool in the mix. Having Node and Yarn should suffice. Yarn doesn't currently support Node 11, and that's why we encounter issues using it. Note that on the Node site version 10 is LTS and "Recommended For Most Users", so I think it's a good decision to stick with that version. Adding Maven to the mix is just another tool that we have to take on and maintain, and I'd like to keep the project as simple as it can be. Using PnP is much more beneficial than using the latest Node version. With PnP we can cache Node modules outside of the git repository which drastically speeds up the build on CI where the build runs on different nodes without any opportunity for caching, so all Node modules are re-downloaded/build.
   
   To use a fixed Node version I believe [nvm](https://github.com/creationix/nvm) is often used. Antora theme already contains `.nvmrc` to do so:
   
   https://github.com/apache/camel-website/blob/460e547b3c4dba09e3452285f06ffbcad1bc0046/antora-ui-camel/.nvmrc#L1
   
   I'd rather see an investment in existing build toolset Node/Yarn/gulp than adding another build tool.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services