You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/08/03 10:43:21 UTC
Re: Review Request 36773: Implemented a LRU entry selection criteria
for cache eviction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 10:43 a.m.)
Review request for mesos, Bernd Mathiske and Joerg Schad.
Bugs: MESOS-3112
https://issues.apache.org/jira/browse/MESOS-3112
Repository: mesos
Description
-------
A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing cache entry is requested, it is moved to the back of the list. During cache eviction entries are removed from the front of the list until enough cache space can be freed.
Diffs (updated)
-----
docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b
src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58
src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe
Diff: https://reviews.apache.org/r/36773/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 36773: Implemented a LRU entry selection criteria
for cache eviction.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93886
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On Aug. 3, 2015, 8:43 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 8:43 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing cache entry is requested, it is moved to the back of the list. During cache eviction entries are removed from the front of the list until enough cache space can be freed.
>
>
> Diffs
> -----
>
> docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b
> src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
> src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58
> src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe
>
> Diff: https://reviews.apache.org/r/36773/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 36773: Implemented a LRU entry selection criteria
for cache eviction.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93889
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 3, 2015, 1:43 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 1:43 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing cache entry is requested, it is moved to the back of the list. During cache eviction entries are removed from the front of the list until enough cache space can be freed.
>
>
> Diffs
> -----
>
> docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b
> src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
> src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58
> src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe
>
> Diff: https://reviews.apache.org/r/36773/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 36773: Implemented a LRU entry selection criteria
for cache eviction.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93882
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36773]
All tests passed.
- Mesos ReviewBot
On Aug. 3, 2015, 8:43 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 8:43 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing cache entry is requested, it is moved to the back of the list. During cache eviction entries are removed from the front of the list until enough cache space can be freed.
>
>
> Diffs
> -----
>
> docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b
> src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
> src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58
> src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe
>
> Diff: https://reviews.apache.org/r/36773/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>