You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/01/29 17:48:44 UTC
[GitHub] [thrift] Jens-G opened a new pull request #2511: THRIFT-5506 + THRIFT-5505
Jens-G opened a new pull request #2511:
URL: https://github.com/apache/thrift/pull/2511
* THRIFT-5506 C26495 variable "t_field::req_" not initialized, t_field.h:40
Compiler General
Patch: Jens Geyer
* THRIFT-5505 error: 'close_generator' overrides a member function but is not marked 'override'
Client: netstd
Patch: Jens Geyer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1057411972
> Is there any way we can help prevent these kinds of problems in the future, before the release? Do you need additional integration tests, or specific git workflows or something?
@jeffalder Great question. It would help to see the builds fail in the existing CI runs. Not sure what needs to be changed (assuming its not a compiler specific thing) but that would certainly help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] jeffalder commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
jeffalder commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1055990095
Yeah, it might be a better idea for us to maintain a fork.
Is there any way we can help prevent these kinds of problems in the future, before the release? Do you need additional integration tests, or specific git workflows or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1059744091
Don't know either. I sent a request to the dev mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1057411972
> Is there any way we can help prevent these kinds of problems in the future, before the release? Do you need additional integration tests, or specific git workflows or something?
Great question. It would help to see the builds fail in the existing CI runs. Not sure what needs to be changed (assuming its not a compiler specific thing) but that would certainly help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] jeffalder commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
jeffalder commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1069989222
I see how homebrew is building bottles. The [homebrew recipe](https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb#L69) includes [ENV.deparallelize](https://rubydoc.brew.sh/Superenv.html#deparallelize-instance_method), which removes the MAKEFLAGS environment variable. In my build log, I see this:
```
clang++ called with: -std=c++11 -DHAVE_CONFIG_H -I./src -Wall -Wextra -pedantic -Werror -g -O2 -MT src/thrift/generate/thrift-t_netstd_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_netstd_generator.Tpo -c -o src/thrift/generate/thrift-t_netstd_generator.o src/thrift/generate/t_netstd_generator.cc
superenv removed: -Wall -Wextra -pedantic -Werror -g -O2
superenv added: -pipe -w -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk --sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -isystem/opt/homebrew/include -isystem/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -I/opt/homebrew/opt/openssl@1.1/include
superenv executed: clang++ -pipe -w -Os -std=c++11 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I./src -MT src/thrift/generate/thrift-t_netstd_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_netstd_generator.Tpo -c -o src/thrift/generate/thrift-t_netstd_generator.o src/thrift/generate/t_netstd_generator.cc -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk --sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -isystem/opt/homebrew/include -isystem/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -I/opt/homebrew/opt/openssl@1.1/include
```
So `ENV.deparallelize` is removing the `-Wall -Wextra -pedantic -Werror` settings, which means that the command-line flag that triggered that error has been removed for homebrew builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] jeffalder commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
jeffalder commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1057529387
I was building on an M1 Mac.
I see there are homebrew bottles built; how do those happen? Can you point me to that?
I also see in `.travis.yml` that the osx builds were causing timeouts, but that looks like a relatively old comment. How was that working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] jeffalder commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
jeffalder commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1054765613
@Jens-G When I download the 0.16.0 source and build locally on my Mac, I get the THRIFT-5505 errors. Do you have any plans to release a 0.16.1 that includes this fix, by any chance?
We don't use the `netstd` generator so I stubbed it out by removing the files. That's how I was able to get it to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
Jens-G merged pull request #2511:
URL: https://github.com/apache/thrift/pull/2511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2511: THRIFT-5506 + THRIFT-5505
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2511:
URL: https://github.com/apache/thrift/pull/2511#issuecomment-1055929996
> Do you have any plans to release a 0.16.1 that includes this fix, by any chance?
Not yet, no.
You probably could cherry pick the patch without much problems yourself, or what am I overlooking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org