You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/02/25 20:13:22 UTC

[GitHub] [hadoop] xiaoyuyao opened a new pull request #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …

xiaoyuyao opened a new pull request #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …
URL: https://github.com/apache/hadoop/pull/1860
 
 
   https://issues.apache.org/jira/browse/HDFS-15192
   
   Fix the leaking stream by ensure the inner stream is closed if the wrapping process hit exception. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …
URL: https://github.com/apache/hadoop/pull/1860#issuecomment-591097886
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 35s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  20m 17s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 46s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   0m 55s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 42s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m  1s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  2s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 39s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 39s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 42s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 54s |  hadoop-hdfs-project: The patch generated 1 new + 35 unchanged - 0 fixed = 36 total (was 35)  |
   | +1 :green_heart: |  mvnsite  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  13m 50s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  0s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   3m 47s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  40m 46s |  hadoop-hdfs in the patch passed.  |
   | -1 :x: |  unit  |   0m 47s |  hadoop-hdfs-nfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 41s |  The patch does not generate ASF License warnings.  |
   |  |   | 119m 52s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy |
   |   | hadoop.hdfs.server.namenode.TestParallelImageWrite |
   |   | hadoop.hdfs.TestFileChecksumCompositeCrc |
   |   | hadoop.hdfs.TestMaintenanceState |
   |   | hadoop.hdfs.TestSmallBlock |
   |   | hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens |
   |   | hadoop.hdfs.TestDFSInputStreamBlockLocations |
   |   | hadoop.hdfs.TestErasureCodingExerciseAPIs |
   |   | hadoop.hdfs.TestDecommission |
   |   | hadoop.hdfs.TestFileCreation |
   |   | hadoop.hdfs.TestBatchedListDirectories |
   |   | hadoop.hdfs.TestDFSStripedOutputStream |
   |   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure |
   |   | hadoop.hdfs.TestLeaseRecovery |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1860 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux c31a2e639384 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / dda00d3 |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-nfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/testReport/ |
   | Max. process+thread count | 3954 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/1/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] jojochuang commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …

Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …
URL: https://github.com/apache/hadoop/pull/1860#issuecomment-594135209
 
 
   LGTM. Triggered a rebuild just to make sure. Don't think the failures are related.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] steveloughran commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …

Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …
URL: https://github.com/apache/hadoop/pull/1860#issuecomment-593389647
 
 
   LGTM; someone from HDFS will have to review including deciding if the test failures are related

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1860: HDFS-15192. Leaking stream when access encrypted files hit exception …
URL: https://github.com/apache/hadoop/pull/1860#issuecomment-594199785
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 48s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m 43s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 35s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   0m 58s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 48s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m  2s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 42s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 39s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 21s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 50s |  hadoop-hdfs-project: The patch generated 1 new + 35 unchanged - 0 fixed = 36 total (was 35)  |
   | +1 :green_heart: |  mvnsite  |   1m 32s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  13m 48s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   3m 45s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  76m 28s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m 42s |  hadoop-hdfs-nfs in the patch passed.  |
   | -1 :x: |  asflicense  |   0m 40s |  The patch generated 541 ASF License warnings.  |
   |  |   | 156m 48s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs |
   |   | hadoop.hdfs.TestByteBufferPread |
   |   | hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy |
   |   | hadoop.hdfs.TestFileChecksumCompositeCrc |
   |   | hadoop.hdfs.TestFsShellPermission |
   |   | hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes |
   |   | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForStoragePolicy |
   |   | hadoop.hdfs.tools.TestECAdmin |
   |   | hadoop.hdfs.TestFileCorruption |
   |   | hadoop.hdfs.TestErasureCodingExerciseAPIs |
   |   | hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs |
   |   | hadoop.hdfs.TestClientProtocolForPipelineRecovery |
   |   | hadoop.hdfs.tools.TestDFSAdmin |
   |   | hadoop.hdfs.TestReplaceDatanodeOnFailure |
   |   | hadoop.hdfs.server.blockmanagement.TestNodeCount |
   |   | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks |
   |   | hadoop.hdfs.TestDFSInotifyEventInputStream |
   |   | hadoop.hdfs.TestParallelUnixDomainRead |
   |   | hadoop.hdfs.TestRestartDFS |
   |   | hadoop.cli.TestHDFSCLI |
   |   | hadoop.hdfs.TestDFSStripedOutputStream |
   |   | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
   |   | hadoop.hdfs.TestDataTransferKeepalive |
   |   | hadoop.hdfs.tools.TestDFSHAAdminMiniCluster |
   |   | hadoop.hdfs.web.TestWebHDFS |
   |   | hadoop.hdfs.tools.TestDFSAdminWithHA |
   |   | hadoop.hdfs.security.TestDelegationTokenForProxyUser |
   |   | hadoop.hdfs.TestHDFSFileSystemContract |
   |   | hadoop.hdfs.TestFileConcurrentReader |
   |   | hadoop.hdfs.TestLeaseRecovery |
   |   | hadoop.cli.TestAclCLIWithPosixAclInheritance |
   |   | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.TestBlockStoragePolicy |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1860 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux ffc7670a779c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / d0a7c79 |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/testReport/ |
   | asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 1588 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1860/2/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org