You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/09/27 10:40:00 UTC
[jira] [Commented] (WICKET-6539) Scope fix for DataTable toolbars
[ https://issues.apache.org/jira/browse/WICKET-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630157#comment-16630157 ]
ASF subversion and git services commented on WICKET-6539:
---------------------------------------------------------
Commit 92b24c98a8e979fd9c2611fc3b919b43ee67c9d2 in wicket's branch refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=92b24c9 ]
WICKET-6539 expose toolbars as WebMarkupContainer
> Scope fix for DataTable toolbars
> --------------------------------
>
> Key: WICKET-6539
> URL: https://issues.apache.org/jira/browse/WICKET-6539
> Project: Wicket
> Issue Type: Wish
> Components: wicket-extensions
> Affects Versions: 8.0.0-M8
> Reporter: Vít Rozkovec
> Priority: Minor
>
> {{I've come across one inconsistency in the DataTable class:}}
> {{ /**}}
> {{ * @return the container with the toolbars at the top}}
> {{ */}}
> {{ public final ToolbarsContainer getTopToolbars()}}
> {{ {}}
> {{ return topToolbars;}}
> {{ /**}}
> {{ * @return the container with the toolbars at the bottom}}
> {{ */}}
> {{ public final ToolbarsContainer getBottomToolbars()}}
> {{ {}}
> {{ return bottomToolbars;}}
> ToolbarsContainer is defined as private, so those methods cannot be used anyway. I suggest either changing the visibility of ToolbarsContainer or removing those methods.
> {{ToolbarsContainer is defined as private, so those methods cannot be used anyway. I suggest either changing the visibility of ToolbarsContainer or removing those methods. I've searched for references and there are not any, though I came across one usecase where I needed to refresh toolbars after ajax update.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)