You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2017/01/16 11:07:41 UTC

Review Request 55569: Log Namenode formatting output into ambari-agent command logs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor Magyari.


Bugs: AMBARI-19559
    https://issues.apache.org/jira/browse/AMBARI-19559


Repository: ambari


Description
-------

NN is being formatted during it's first startup. The script used for formatting NN logs to standard output which currently is being collected only in DEBUG mode by ambari agent thus is lost in production environments where the agent usually runs in non-DEBUG mode. The NN formatting log is useful for trouble shooting thus these should be collected and written out into the NN start command output log.
This can be done by adding logoutput=True option to the NN format script invocation within NN start script.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py cc03bb3 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py 2c0d691 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py 35e16d5 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 

Diff: https://reviews.apache.org/r/55569/diff/


Testing
-------

Testing manually cluster creation with both using the wizzard and blueprint (NN non-HA and HA).

Unit tests:

mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests

OK
----------------------------------------------------------------------
Total run:1159
Total errors:0
Total failures:0
OK


Thanks,

Sebastian Toader


Re: Review Request 55569: Log Namenode formatting output into ambari-agent command logs

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/#review161719
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Magyar


On Jan. 16, 2017, 11:07 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55569/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 11:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19559
>     https://issues.apache.org/jira/browse/AMBARI-19559
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NN is being formatted during it's first startup. The script used for formatting NN logs to standard output which currently is being collected only in DEBUG mode by ambari agent thus is lost in production environments where the agent usually runs in non-DEBUG mode. The NN formatting log is useful for trouble shooting thus these should be collected and written out into the NN start command output log.
> This can be done by adding logoutput=True option to the NN format script invocation within NN start script.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py cc03bb3 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py 2c0d691 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py 35e16d5 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 
> 
> Diff: https://reviews.apache.org/r/55569/diff/
> 
> 
> Testing
> -------
> 
> Testing manually cluster creation with both using the wizzard and blueprint (NN non-HA and HA).
> 
> Unit tests:
> 
> mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests
> 
> OK
> ----------------------------------------------------------------------
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Re: Review Request 55569: Log Namenode formatting output into ambari-agent command logs

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55569/#review161716
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On Jan. 16, 2017, 12:07 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55569/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19559
>     https://issues.apache.org/jira/browse/AMBARI-19559
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NN is being formatted during it's first startup. The script used for formatting NN logs to standard output which currently is being collected only in DEBUG mode by ambari agent thus is lost in production environments where the agent usually runs in non-DEBUG mode. The NN formatting log is useful for trouble shooting thus these should be collected and written out into the NN start command output log.
> This can be done by adding logoutput=True option to the NN format script invocation within NN start script.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py cc03bb3 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py 2c0d691 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py 35e16d5 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py f76a7d7 
> 
> Diff: https://reviews.apache.org/r/55569/diff/
> 
> 
> Testing
> -------
> 
> Testing manually cluster creation with both using the wizzard and blueprint (NN non-HA and HA).
> 
> Unit tests:
> 
> mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests
> 
> OK
> ----------------------------------------------------------------------
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>