You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/08/01 08:03:28 UTC
Re: Review Request 70831: Fixed synchronization in
MasterTest.UpdateSlaveMessageWithPendingOffers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70831/#review217025
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On June 11, 2019, 12:38 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70831/
> -----------------------------------------------------------
>
> (Updated June 11, 2019, 12:38 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order for a resource provider to have been assigned and stored an
> assigned resource provider ID it needs to receive and process the
> corresponding resource provider `SUBSCRIBED` event.
>
> This patch fixes `MasterTest.UpdateSlaveMessageWithPendingOffers` so we
> await the correct event. The test was previously awaiting an
> `UpdateSlaveMessage` which is only tangentially related, but does not
> guarantee correct event ordering.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e
>
>
> Diff: https://reviews.apache.org/r/70831/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>