You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/31 18:16:06 UTC
[GitHub] [beam] angoenka commented on a change in pull request #10717:
[BEAM-8280] Enable type hint annotations
angoenka commented on a change in pull request #10717: [BEAM-8280] Enable type hint annotations
URL: https://github.com/apache/beam/pull/10717#discussion_r401117161
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -138,8 +139,7 @@ def foo((a, b)):
_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
-# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
-_enable_from_callable = False
+_disable_from_callable = False
Review comment:
Should this be True? (based on the check in line 234)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services