You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/05 18:48:15 UTC
[PR] test(amber): add AmberKryoInitializer spec [texera]
Ma77Ball opened a new pull request, #5387:
URL: https://github.com/apache/texera/pull/5387
### What changes were proposed in this PR?
- Add `AmberKryoInitializerSpec`, the first test for the Kryo closure-serialization setup that lets Pekko move Scala closures between workers.
- Assert `preInit` registers `SerializedLambda` and binds `ClosureSerializer.Closure` to a `ClosureSerializer`, with a negative control proving a bare `ScalaKryo` has neither.
- Add behavioral round-trips: a Scala closure serializes and deserializes back to a working function, and two closures capturing different locals stay independent.
### Any related issues, documentation, or discussions?
N/A
### How was this PR tested?
- Run `sbt "WorkflowExecutionService/testOnly *AmberKryoInitializerSpec"` and expect 4 examples to pass.
- Local sbt test runs are blocked by JaCoCo 0.8.11 (cannot instrument Java 25 bytecode, major version 69), so the suite was run directly via ScalaTest off the dependency classpath (`java -cp ... org.scalatest.tools.Runner -s ...AmberKryoInitializerSpec` with `--add-opens java.base/java.lang.invoke=ALL-UNNAMED`); all 4 passed. CI runs it on a supported JDK.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add AmberKryoInitializer spec [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5387:
URL: https://github.com/apache/texera/pull/5387#issuecomment-4634584522
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5387?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 51.62%. Comparing base ([`8a4cb29`](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3ab36d4`](https://app.codecov.io/gh/apache/texera/commit/3ab36d429f42beaacf7d7339e07e90c473a11d82?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5387 +/- ##
============================================
- Coverage 51.62% 51.62% -0.01%
Complexity 2420 2420
============================================
Files 1056 1056
Lines 41046 41046
Branches 4407 4407
============================================
- Hits 21190 21189 -1
- Misses 18617 18618 +1
Partials 1239 1239
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.89% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.22% <ø> (-0.01%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.38% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.68% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.42% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.32% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.69% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.84% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.39% <ø> (ø)` | | Carriedforward from [8a4cb29](https://app.codecov.io/gh/apache/texera/commit/8a4cb29e1045f18cbfaf5f143473e0f05b25d4ea?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5387?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add AmberKryoInitializer spec [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5387:
URL: https://github.com/apache/texera/pull/5387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org