[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1986: [bug]batch job end ingress is not deleted

[GitBox <gi...@apache.org>]

wolfboys commented on code in PR #1986:
URL: https://github.com/apache/incubator-streampark/pull/1986#discussion_r1016295205


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/K8sFlinkChangeEventListener.java:
##########
@@ -165,6 +165,7 @@ private void updateApplicationWithJobStatusCV(Application app, JobStatusCV jobSt
         app.setJobId(jobStatus.jobId());
         app.setTotalTask(jobStatus.taskTotal());
         if (FlinkJobState.isEndState(state)) {
+            IngressController.deleteIngress(app.getJobName(), app.getK8sNamespace());

Review Comment:
   I have two questions:
   1) The judgment here can be combined with line 182.
   2) I don't know if FlinkJobState.isEndState == true, is need to call `IngressController.deleteIngress`? if right, You can check it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org