You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/10 04:54:28 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request #14638: Fix wrong prompt exception when get non-persistent topic list without GET_BUDNLE permission
Technoboy- opened a new pull request #14638:
URL: https://github.com/apache/pulsar/pull/14638
Fixes #14191
### Motivation
We have some big issues with the permission part. We only have the permission with [doc](https://pulsar.apache.org/docs/en/admin-api-permissions/) mentioned. But if user do it according to the doc, they will face the same issue that #14191 described. We don't have GET_BUNDLE in the grant interface but given the prompt message to the user. And currently, only the admin role could have the permission.
This pr is not solving the permission issue but fixing the prompt message first, not giving 500 error to the user. Then I will open an issue to discuss refactoring the permission part.
### Modification
- Return 403 to the user when permission is denied.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14638: Fix wrong prompt exception when get non-persistent topic list without GET_BUDNLE permission
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14638:
URL: https://github.com/apache/pulsar/pull/14638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #14638: Fix wrong prompt exception when get non-persistent topic list without GET_BUDNLE permission
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #14638:
URL: https://github.com/apache/pulsar/pull/14638#issuecomment-1065129361
> LGTM. Do we need to apply these changes to v1 API as well?
Yes, thanks. Updated for v1.
Beside, We may not update non-persistent topics in v1 for a long time, there is an NPE in the getList and getListFromBundle .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org