[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10465: Provide all stats metadata to queries run by pinot-java-client

["swaminathanmanish (via GitHub)" <gi...@apache.org>]

swaminathanmanish commented on code in PR #10465:
URL: https://github.com/apache/pinot/pull/10465#discussion_r1146956437


##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java:
##########
@@ -115,20 +113,6 @@ public long getTimeUsedMs() {
 
   @Override
   public String toString() {
-    Map<String, Object> map = new HashMap<>();
-    map.put(NUM_SERVERS_QUERIED, getNumServersQueried());
-    map.put(NUM_SERVERS_RESPONDED, getNumServersResponded());
-    map.put(NUM_DOCS_SCANNED, getNumDocsScanned());
-    map.put(NUM_ENTRIES_SCANNED_IN_FILTER, getNumEntriesScannedInFilter());
-    map.put(NUM_ENTRIES_SCANNED_POST_FILTER, getNumEntriesScannedPostFilter());
-    map.put(NUM_SEGMENTS_QUERIED, getNumSegmentsQueried());
-    map.put(NUM_SEGMENTS_PROCESSED, getNumSegmentsProcessed());
-    map.put(NUM_SEGMENTS_MATCHED, getNumSegmentsMatched());
-    map.put(NUM_CONSUMING_SEGMENTS_QUERIED, getNumConsumingSegmentsQueried());
-    map.put(MIN_CONSUMING_FRESHNESS_TIME_MS, getMinConsumingFreshnessTimeMs() + "ms");
-    map.put(TOTAL_DOCS, getTotalDocs());
-    map.put(NUM_GROUPS_LIMIT_REACHED, isNumGroupsLimitReached());
-    map.put(TIME_USED_MS, getTimeUsedMs() + "ms");
-    return map.toString();
+    return _brokerResponse.toString();

Review Comment:
   Curious why we were selectively pulling out stats in the first place?  Any idea what other stats we will get to see. 
   This is the PR that added - https://github.com/apache/pinot/pull/5892/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org