[GitHub] [incubator-apisix] chnliyong opened a new pull request #894: Resolve #882 and simplify conf

[GitBox <gi...@apache.org>]

chnliyong opened a new pull request #894: Resolve #882 and simplify conf
URL: https://github.com/apache/incubator-apisix/pull/894
 
 
   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   Resolve issue #882 and simplify the nginx.conf
   Also fix `utils/install-apisix.sh` as on `Debian/Ubuntu` the /bin/sh is a symbolic refer `/bin/dash` rather than `/bin/bash`, which not support `==` equal comparation.
   ```shell
   $ ls -l /bin/sh
   lrwxrwxrwx 1 root root 4 Oct  8 23:49 /bin/sh -> dash
   ```
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #882 
   
   1. The dashboard resources doesn't need proxy pass to upstream, remove the redundant `proxy_set_header`.
   2. The direcctive `index index.html` is [the default setting by nginx](https://nginx.org/en/docs/http/ngx_http_index_module.html#index), remove it.
   3. The internal redirect by `ngx.exec` is used to handle uri `/apisix/dashboard`, with can be solved by using `$uri/index.html` in `try_files`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services