[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #582: add epoch to handle create producer timeout

[GitBox <gi...@apache.org>]

cckellogg commented on a change in pull request #582:
URL: https://github.com/apache/pulsar-client-go/pull/582#discussion_r684325898



##########
File path: pulsar/producer_partition.go
##########
@@ -79,6 +79,9 @@ type partitionProducer struct {
 	schemaInfo       *SchemaInfo
 	partitionIdx     int32
 	metrics          *internal.TopicMetrics
+
+	epoch                    uint64
+	userProvidedProducerName bool

Review comment:
       Can this `userProvidedProducerName`  just be determined when creating the producer command from the name? Why create an extra variable?

##########
File path: pulsar/producer_partition.go
##########
@@ -136,6 +142,7 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions
 	p.log = p.log.SubLogger(log.Fields{
 		"producer_name": p.producerName,
 		"producerID":    p.producerID,
+		"epoch":         atomic.LoadUint64(&p.epoch),

Review comment:
       Will this always log the same the same value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org