You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Steve Huston <sh...@riverace.com> on 2012/07/27 04:26:34 UTC
Re: Review Request: QPID-4084: Change format of qpidd
--log-highres-timestamp to be more consistent with Linux
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5624/
-----------------------------------------------------------
(Updated July 27, 2012, 2:26 a.m.)
Review request for qpid and Alan Conway.
Changes
-------
Changed to incorporate Chuck Rolke's suggestion to use high-performance counter instead of relying solely on filetime. Time format is the same on output but will be more accurate.
Description
-------
This patch changes from seconds-since-start format to time-with-microseconds time when --log-highres-timestamp yes is supplied. This is closer to the Linux output, though Linux logs with nanoseconds while Windows logs with microseconds.
The output on Windows will change from something like this:
0000000.00000798s [Security] error Failed to initialise SSL listener: Locating c
ertificate smokey-win7 in store My Cannot find object or property. (E:\qpid\tru
nk\qpid\cpp\src\qpid\broker\windows\SslProtocolFactory.cpp:193)
0000000.07750290s [Network] notice Listening on TCP/TCP6 port 5672
5672
0000000.10241085s [Broker] notice Broker running
0000005.32722109s [Broker] notice Shut down
to this:
2012-06-27 19:55:25.403936 [Security] error Failed to initialise SSL listener: L
ocating certificate smokey-win7 in store My Cannot find object or property. (E:
\qpid\trunk\qpid\cpp\src\qpid\broker\windows\SslProtocolFactory.cpp:193)
2012-06-27 19:55:25.497537 [Network] notice Listening on TCP/TCP6 port 5672
5672
2012-06-27 19:55:25.528737 [Broker] notice Broker running
2012-06-27 19:55:42.891551 [Broker] notice Shut down
This addresses bug QPID-4084.
https://issues.apache.org/jira/browse/QPID-4084
Diffs (updated)
-----
trunk/qpid/cpp/src/qpid/sys/windows/Time.cpp 1365859
Diff: https://reviews.apache.org/r/5624/diff/
Testing
-------
Build, run qpidd with --log-highres-timestamp yes enabled. Sanity check the times displayed.
Thanks,
Steve Huston
Re: Review Request: QPID-4084: Change format of qpidd
--log-highres-timestamp to be more consistent with Linux
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5624/#review9531
-----------------------------------------------------------
Ship it!
Ship It!
- Alan Conway
On July 27, 2012, 2:26 a.m., Steve Huston wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5624/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 2:26 a.m.)
>
>
> Review request for qpid and Alan Conway.
>
>
> Description
> -------
>
> This patch changes from seconds-since-start format to time-with-microseconds time when --log-highres-timestamp yes is supplied. This is closer to the Linux output, though Linux logs with nanoseconds while Windows logs with microseconds.
>
> The output on Windows will change from something like this:
>
> 0000000.00000798s [Security] error Failed to initialise SSL listener: Locating c
> ertificate smokey-win7 in store My Cannot find object or property. (E:\qpid\tru
> nk\qpid\cpp\src\qpid\broker\windows\SslProtocolFactory.cpp:193)
> 0000000.07750290s [Network] notice Listening on TCP/TCP6 port 5672
> 5672
> 0000000.10241085s [Broker] notice Broker running
> 0000005.32722109s [Broker] notice Shut down
>
> to this:
>
> 2012-06-27 19:55:25.403936 [Security] error Failed to initialise SSL listener: L
> ocating certificate smokey-win7 in store My Cannot find object or property. (E:
> \qpid\trunk\qpid\cpp\src\qpid\broker\windows\SslProtocolFactory.cpp:193)
> 2012-06-27 19:55:25.497537 [Network] notice Listening on TCP/TCP6 port 5672
> 5672
> 2012-06-27 19:55:25.528737 [Broker] notice Broker running
> 2012-06-27 19:55:42.891551 [Broker] notice Shut down
>
>
> This addresses bug QPID-4084.
> https://issues.apache.org/jira/browse/QPID-4084
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/sys/windows/Time.cpp 1365859
>
> Diff: https://reviews.apache.org/r/5624/diff/
>
>
> Testing
> -------
>
> Build, run qpidd with --log-highres-timestamp yes enabled. Sanity check the times displayed.
>
>
> Thanks,
>
> Steve Huston
>
>