You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/10/10 12:03:13 UTC
Review Request 39205: Deprecate resource_monitoring_interval flag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
-------
This flag should be deprecated after 0.23.0 as it is no use now.
Diffs
-----
docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
Diff: https://reviews.apache.org/r/39205/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 39205: Deprecate resource_monitoring_interval flag
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/#review102230
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Oct. 12, 2015, 3:32 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39205/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 3:32 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-3700
> https://issues.apache.org/jira/browse/MESOS-3700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag should be deprecated after 0.23.0 as it is no use now.
>
>
> Diffs
> -----
>
> docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
> docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
> src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
> src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
> src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
> src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
>
> Diff: https://reviews.apache.org/r/39205/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39205: Deprecate resource_monitoring_interval flag
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/#review102361
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 11, 2015, 8:32 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39205/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2015, 8:32 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-3700
> https://issues.apache.org/jira/browse/MESOS-3700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag should be deprecated after 0.23.0 as it is no use now.
>
>
> Diffs
> -----
>
> docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
> docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
> src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
> src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
> src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
> src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
>
> Diff: https://reviews.apache.org/r/39205/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39205: Deprecate resource_monitoring_interval flag
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/
-----------------------------------------------------------
(Updated 十月 12, 2015, 3:32 a.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-3700
https://issues.apache.org/jira/browse/MESOS-3700
Repository: mesos
Description
-------
This flag should be deprecated after 0.23.0 as it is no use now.
Diffs
-----
docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
Diff: https://reviews.apache.org/r/39205/diff/
Testing
-------
make check
Thanks,
Guangya Liu
Re: Review Request 39205: Deprecate resource_monitoring_interval flag
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/#review102165
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39205]
All tests passed.
- Mesos ReviewBot
On Oct. 10, 2015, 10:03 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39205/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 10:03 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag should be deprecated after 0.23.0 as it is no use now.
>
>
> Diffs
> -----
>
> docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
> docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
> src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
> src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
> src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
> src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
>
> Diff: https://reviews.apache.org/r/39205/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39205: Deprecate resource_monitoring_interval flag
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/
-----------------------------------------------------------
(Updated 十月 10, 2015, 10:03 a.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
-------
This flag should be deprecated after 0.23.0 as it is no use now.
Diffs
-----
docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e
docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24
src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341
src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55
src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
Diff: https://reviews.apache.org/r/39205/diff/
Testing (updated)
-------
make check
Thanks,
Guangya Liu