You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "philip hoy (JIRA)" <ji...@apache.org> on 2013/05/16 16:57:15 UTC
[jira] [Comment Edited] (SOLR-4823) Split LBHttpSolrServer into two
classes one for the solrj use case and one for the solr cloud use case
[ https://issues.apache.org/jira/browse/SOLR-4823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659604#comment-13659604 ]
philip hoy edited comment on SOLR-4823 at 5/16/13 2:57 PM:
-----------------------------------------------------------
Here is a first stab at a refactoring, it is without any additional test coverage at present and may well be a bit too much to swallow. However I am happy to revisit it.
Interestingly moving the cloud load balancing code out of LBHttpSolrServer did not affect any tests so perhaps that use case could do with some extra test coverage.
was (Author: phloy):
Here is a first stab at a refactorig, it is without any additional test coverage at present and may well be a bit to much to swallow. However I am happy to revisit it. Interestingly moving the cloud load balancing code out of LBHttpSolrServer did not affect any tests so perhaps that use case could use some extra test coverage.
> Split LBHttpSolrServer into two classes one for the solrj use case and one for the solr cloud use case
> ------------------------------------------------------------------------------------------------------
>
> Key: SOLR-4823
> URL: https://issues.apache.org/jira/browse/SOLR-4823
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: philip hoy
> Priority: Minor
> Attachments: SOLR-4823.patch
>
>
> The LBHttpSolrServer has too many responsibilities. It could perhaps be broken into two classes, one in solrj to be used in the place of an external load balancer that balances across a known set of solr servers defined at construction time and one in solr core to be used by the solr cloud components that balances across servers dependant on the request.
> To save code duplication, if much arises an abstract bass class could be introduced in to solrj.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org