You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Gilbert Song <gi...@mesosphere.io> on 2016/03/08 20:33:29 UTC

Executors no longer inherit environment variables from the agent

Hi,

TL;DR Executors will no longer inherit environment variables from the agent
by default in 0.30.

Currently, executors are inheriting environment variables form the agent in
mesos containerizer by default. This is an unfortunate legacy behavior and
is insecure. If you do have environment variables that you want to pass to
the executors, you can set it explicitly by using the
`--executor_environment_variables` agent flag.

Starting from 0.30, we will no longer allow executors to inherit
environment variables from the agent. In other words,
`--executor_environment_variables` will be set to “{}” by default. If you
do depend on the original behavior, please set
`--executor_environment_variables` flag explicitly.

Let us know if you have any comments or concerns.

Thanks,
Gilbert

Fwd: Executors no longer inherit environment variables from the agent

Posted by Joshua Cohen <jc...@apache.org>.
I just spent some time to dig into this and it looks like we *will* be
impacted by this. I updated mesos-slave.conf in Vagrant to pass
--executor_environment_variables='{}' and as predicted by this pull
request: https://github.com/apache/aurora/pull/21, sys.executable is empty,
so we fail to fork the runner.

Unfortunately even after applying that patch, there still seem to be issues
with forking processes. I've filed
https://issues.apache.org/jira/browse/AURORA-1632 to track the
investigation and fixes so we're not blocked when Mesos 0.30.0 is released.

---------- Forwarded message ----------
From: Gilbert Song <gi...@mesosphere.io>
Date: Tue, Mar 8, 2016 at 1:33 PM
Subject: Executors no longer inherit environment variables from the agent
To: dev@mesos.apache.org, user@mesos.apache.org


Hi,

TL;DR Executors will no longer inherit environment variables from the agent
by default in 0.30.

Currently, executors are inheriting environment variables form the agent in
mesos containerizer by default. This is an unfortunate legacy behavior and
is insecure. If you do have environment variables that you want to pass to
the executors, you can set it explicitly by using the
`--executor_environment_variables` agent flag.

Starting from 0.30, we will no longer allow executors to inherit
environment variables from the agent. In other words,
`--executor_environment_variables` will be set to “{}” by default. If you
do depend on the original behavior, please set
`--executor_environment_variables` flag explicitly.

Let us know if you have any comments or concerns.

Thanks,
Gilbert

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
Alex,

See my response inlined:

First, does this change include the executor library? We currently use
> environment variables to propagate various config values from an agent to
> executors. If it does, what is the alternative?


Any environment variables generated by Mesos (i.e., MESOS_, LIBPROCESS_)
will not be affected.

Second, what will be the preferred way to pass config values to executors?
> It would be great to be able to do it uniformly for non-HTTP and HTTP
> executors. I can think of several possibilities: cmd flags, adding or
> overriding protobufs, extending Executor interface.


You can always use the Environments in ExecutorInfo.CommandInfo or
TaskInfo.CommandInfo to pass in environment variables to executors/tasks.

- Jie

On Thu, Mar 10, 2016 at 3:50 AM, Alex Rukletsov <al...@mesosphere.com> wrote:

> I have two questions.
>
> First, does this change include the executor library? We currently use
> environment variables to propagate various config values from an agent to
> executors. If it does, what is the alternative?
>
> Second, what will be the preferred way to pass config values to executors?
> It would be great to be able to do it uniformly for non-HTTP and HTTP
> executors. I can think of several possibilities: cmd flags, adding or
> overriding protobufs, extending Executor interface.
>
> On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
>> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still
>> have `LIBPROCESS_IP` set and passed to executors' environment, which is for
>> the case that DNS is not available on the slave.
>>
>> Gilbert
>>
>> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:
>>
>>> Is LIBPROCESS_IP going to be an exception to this? Some executors are
>>> using this variable as an alternative of implementing their own IP
>>> detection logic AFAIK so this behavior would break them.
>>>
>>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> TL;DR Executors will no longer inherit environment variables from the
>>>> agent by default in 0.30.
>>>>
>>>> Currently, executors are inheriting environment variables form the
>>>> agent in mesos containerizer by default. This is an unfortunate legacy
>>>> behavior and is insecure. If you do have environment variables that you
>>>> want to pass to the executors, you can set it explicitly by using the
>>>> `--executor_environment_variables` agent flag.
>>>>
>>>> Starting from 0.30, we will no longer allow executors to inherit
>>>> environment variables from the agent. In other words,
>>>> `--executor_environment_variables` will be set to “{}” by default. If you
>>>> do depend on the original behavior, please set
>>>> `--executor_environment_variables` flag explicitly.
>>>>
>>>> Let us know if you have any comments or concerns.
>>>>
>>>> Thanks,
>>>> Gilbert
>>>>
>>>
>>>
>>>
>>> --
>>> Cheers,
>>>
>>> Zhitao Li
>>>
>>
>>
>

Re: Executors no longer inherit environment variables from the agent

Posted by Alexander Rojas <al...@mesosphere.io>.
Not that I know a lot about this project, but I think for the command executor we can use the `Environment` message. Perhaps we can extend the container info to have something similar?


> On 10 Mar 2016, at 12:50, Alex Rukletsov <al...@mesosphere.com> wrote:
> 
> I have two questions.
> 
> First, does this change include the executor library? We currently use environment variables to propagate various config values from an agent to executors. If it does, what is the alternative?
> 
> Second, what will be the preferred way to pass config values to executors? It would be great to be able to do it uniformly for non-HTTP and HTTP executors. I can think of several possibilities: cmd flags, adding or overriding protobufs, extending Executor interface.
> 
> On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gilbert@mesosphere.io <ma...@mesosphere.io>> wrote:
> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have `LIBPROCESS_IP` set and passed to executors' environment, which is for the case that DNS is not available on the slave.
> 
> Gilbert
> 
> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zhitaoli.cs@gmail.com <ma...@gmail.com>> wrote:
> Is LIBPROCESS_IP going to be an exception to this? Some executors are using this variable as an alternative of implementing their own IP detection logic AFAIK so this behavior would break them.
> 
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gilbert@mesosphere.io <ma...@mesosphere.io>> wrote:
> Hi,
> 
> TL;DR Executors will no longer inherit environment variables from the agent by default in 0.30.
> 
> Currently, executors are inheriting environment variables form the agent in mesos containerizer by default. This is an unfortunate legacy behavior and is insecure. If you do have environment variables that you want to pass to the executors, you can set it explicitly by using the `--executor_environment_variables` agent flag.
> 
> Starting from 0.30, we will no longer allow executors to inherit environment variables from the agent. In other words, `--executor_environment_variables` will be set to “{}” by default. If you do depend on the original behavior, please set `--executor_environment_variables` flag explicitly.
> 
> Let us know if you have any comments or concerns.
> 
> Thanks,
> Gilbert
> 
> 
> 
> -- 
> Cheers,
> 
> Zhitao Li
> 
> 


Re: Executors no longer inherit environment variables from the agent

Posted by Alexander Rojas <al...@mesosphere.io>.
Not that I know a lot about this project, but I think for the command executor we can use the `Environment` message. Perhaps we can extend the container info to have something similar?


> On 10 Mar 2016, at 12:50, Alex Rukletsov <al...@mesosphere.com> wrote:
> 
> I have two questions.
> 
> First, does this change include the executor library? We currently use environment variables to propagate various config values from an agent to executors. If it does, what is the alternative?
> 
> Second, what will be the preferred way to pass config values to executors? It would be great to be able to do it uniformly for non-HTTP and HTTP executors. I can think of several possibilities: cmd flags, adding or overriding protobufs, extending Executor interface.
> 
> On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gilbert@mesosphere.io <ma...@mesosphere.io>> wrote:
> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have `LIBPROCESS_IP` set and passed to executors' environment, which is for the case that DNS is not available on the slave.
> 
> Gilbert
> 
> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zhitaoli.cs@gmail.com <ma...@gmail.com>> wrote:
> Is LIBPROCESS_IP going to be an exception to this? Some executors are using this variable as an alternative of implementing their own IP detection logic AFAIK so this behavior would break them.
> 
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gilbert@mesosphere.io <ma...@mesosphere.io>> wrote:
> Hi,
> 
> TL;DR Executors will no longer inherit environment variables from the agent by default in 0.30.
> 
> Currently, executors are inheriting environment variables form the agent in mesos containerizer by default. This is an unfortunate legacy behavior and is insecure. If you do have environment variables that you want to pass to the executors, you can set it explicitly by using the `--executor_environment_variables` agent flag.
> 
> Starting from 0.30, we will no longer allow executors to inherit environment variables from the agent. In other words, `--executor_environment_variables` will be set to “{}” by default. If you do depend on the original behavior, please set `--executor_environment_variables` flag explicitly.
> 
> Let us know if you have any comments or concerns.
> 
> Thanks,
> Gilbert
> 
> 
> 
> -- 
> Cheers,
> 
> Zhitao Li
> 
> 


Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
Alex,

See my response inlined:

First, does this change include the executor library? We currently use
> environment variables to propagate various config values from an agent to
> executors. If it does, what is the alternative?


Any environment variables generated by Mesos (i.e., MESOS_, LIBPROCESS_)
will not be affected.

Second, what will be the preferred way to pass config values to executors?
> It would be great to be able to do it uniformly for non-HTTP and HTTP
> executors. I can think of several possibilities: cmd flags, adding or
> overriding protobufs, extending Executor interface.


You can always use the Environments in ExecutorInfo.CommandInfo or
TaskInfo.CommandInfo to pass in environment variables to executors/tasks.

- Jie

On Thu, Mar 10, 2016 at 3:50 AM, Alex Rukletsov <al...@mesosphere.com> wrote:

> I have two questions.
>
> First, does this change include the executor library? We currently use
> environment variables to propagate various config values from an agent to
> executors. If it does, what is the alternative?
>
> Second, what will be the preferred way to pass config values to executors?
> It would be great to be able to do it uniformly for non-HTTP and HTTP
> executors. I can think of several possibilities: cmd flags, adding or
> overriding protobufs, extending Executor interface.
>
> On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
>> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still
>> have `LIBPROCESS_IP` set and passed to executors' environment, which is for
>> the case that DNS is not available on the slave.
>>
>> Gilbert
>>
>> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:
>>
>>> Is LIBPROCESS_IP going to be an exception to this? Some executors are
>>> using this variable as an alternative of implementing their own IP
>>> detection logic AFAIK so this behavior would break them.
>>>
>>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> TL;DR Executors will no longer inherit environment variables from the
>>>> agent by default in 0.30.
>>>>
>>>> Currently, executors are inheriting environment variables form the
>>>> agent in mesos containerizer by default. This is an unfortunate legacy
>>>> behavior and is insecure. If you do have environment variables that you
>>>> want to pass to the executors, you can set it explicitly by using the
>>>> `--executor_environment_variables` agent flag.
>>>>
>>>> Starting from 0.30, we will no longer allow executors to inherit
>>>> environment variables from the agent. In other words,
>>>> `--executor_environment_variables` will be set to “{}” by default. If you
>>>> do depend on the original behavior, please set
>>>> `--executor_environment_variables` flag explicitly.
>>>>
>>>> Let us know if you have any comments or concerns.
>>>>
>>>> Thanks,
>>>> Gilbert
>>>>
>>>
>>>
>>>
>>> --
>>> Cheers,
>>>
>>> Zhitao Li
>>>
>>
>>
>

Re: Executors no longer inherit environment variables from the agent

Posted by Alex Rukletsov <al...@mesosphere.com>.
I have two questions.

First, does this change include the executor library? We currently use
environment variables to propagate various config values from an agent to
executors. If it does, what is the alternative?

Second, what will be the preferred way to pass config values to executors?
It would be great to be able to do it uniformly for non-HTTP and HTTP
executors. I can think of several possibilities: cmd flags, adding or
overriding protobufs, extending Executor interface.

On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gi...@mesosphere.io> wrote:

> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have
> `LIBPROCESS_IP` set and passed to executors' environment, which is for the
> case that DNS is not available on the slave.
>
> Gilbert
>
> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:
>
>> Is LIBPROCESS_IP going to be an exception to this? Some executors are
>> using this variable as an alternative of implementing their own IP
>> detection logic AFAIK so this behavior would break them.
>>
>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>> wrote:
>>
>>> Hi,
>>>
>>> TL;DR Executors will no longer inherit environment variables from the
>>> agent by default in 0.30.
>>>
>>> Currently, executors are inheriting environment variables form the agent
>>> in mesos containerizer by default. This is an unfortunate legacy behavior
>>> and is insecure. If you do have environment variables that you want to pass
>>> to the executors, you can set it explicitly by using the
>>> `--executor_environment_variables` agent flag.
>>>
>>> Starting from 0.30, we will no longer allow executors to inherit
>>> environment variables from the agent. In other words,
>>> `--executor_environment_variables` will be set to “{}” by default. If you
>>> do depend on the original behavior, please set
>>> `--executor_environment_variables` flag explicitly.
>>>
>>> Let us know if you have any comments or concerns.
>>>
>>> Thanks,
>>> Gilbert
>>>
>>
>>
>>
>> --
>> Cheers,
>>
>> Zhitao Li
>>
>
>

Re: Executors no longer inherit environment variables from the agent

Posted by Alex Rukletsov <al...@mesosphere.com>.
I have two questions.

First, does this change include the executor library? We currently use
environment variables to propagate various config values from an agent to
executors. If it does, what is the alternative?

Second, what will be the preferred way to pass config values to executors?
It would be great to be able to do it uniformly for non-HTTP and HTTP
executors. I can think of several possibilities: cmd flags, adding or
overriding protobufs, extending Executor interface.

On Tue, Mar 8, 2016 at 9:21 PM, Gilbert Song <gi...@mesosphere.io> wrote:

> Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have
> `LIBPROCESS_IP` set and passed to executors' environment, which is for the
> case that DNS is not available on the slave.
>
> Gilbert
>
> On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:
>
>> Is LIBPROCESS_IP going to be an exception to this? Some executors are
>> using this variable as an alternative of implementing their own IP
>> detection logic AFAIK so this behavior would break them.
>>
>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>> wrote:
>>
>>> Hi,
>>>
>>> TL;DR Executors will no longer inherit environment variables from the
>>> agent by default in 0.30.
>>>
>>> Currently, executors are inheriting environment variables form the agent
>>> in mesos containerizer by default. This is an unfortunate legacy behavior
>>> and is insecure. If you do have environment variables that you want to pass
>>> to the executors, you can set it explicitly by using the
>>> `--executor_environment_variables` agent flag.
>>>
>>> Starting from 0.30, we will no longer allow executors to inherit
>>> environment variables from the agent. In other words,
>>> `--executor_environment_variables` will be set to “{}” by default. If you
>>> do depend on the original behavior, please set
>>> `--executor_environment_variables` flag explicitly.
>>>
>>> Let us know if you have any comments or concerns.
>>>
>>> Thanks,
>>> Gilbert
>>>
>>
>>
>>
>> --
>> Cheers,
>>
>> Zhitao Li
>>
>
>

Re: Executors no longer inherit environment variables from the agent

Posted by Gilbert Song <gi...@mesosphere.io>.
Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have
`LIBPROCESS_IP` set and passed to executors' environment, which is for the
case that DNS is not available on the slave.

Gilbert

On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:

> Is LIBPROCESS_IP going to be an exception to this? Some executors are
> using this variable as an alternative of implementing their own IP
> detection logic AFAIK so this behavior would break them.
>
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
>> Hi,
>>
>> TL;DR Executors will no longer inherit environment variables from the
>> agent by default in 0.30.
>>
>> Currently, executors are inheriting environment variables form the agent
>> in mesos containerizer by default. This is an unfortunate legacy behavior
>> and is insecure. If you do have environment variables that you want to pass
>> to the executors, you can set it explicitly by using the
>> `--executor_environment_variables` agent flag.
>>
>> Starting from 0.30, we will no longer allow executors to inherit
>> environment variables from the agent. In other words,
>> `--executor_environment_variables` will be set to “{}” by default. If you
>> do depend on the original behavior, please set
>> `--executor_environment_variables` flag explicitly.
>>
>> Let us know if you have any comments or concerns.
>>
>> Thanks,
>> Gilbert
>>
>
>
>
> --
> Cheers,
>
> Zhitao Li
>

Re: Executors no longer inherit environment variables from the agent

Posted by Gilbert Song <gi...@mesosphere.io>.
Yes, `LIBPROCESS_IP` will be excepted from this change. We will still have
`LIBPROCESS_IP` set and passed to executors' environment, which is for the
case that DNS is not available on the slave.

Gilbert

On Tue, Mar 8, 2016 at 11:57 AM, Zhitao Li <zh...@gmail.com> wrote:

> Is LIBPROCESS_IP going to be an exception to this? Some executors are
> using this variable as an alternative of implementing their own IP
> detection logic AFAIK so this behavior would break them.
>
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
>> Hi,
>>
>> TL;DR Executors will no longer inherit environment variables from the
>> agent by default in 0.30.
>>
>> Currently, executors are inheriting environment variables form the agent
>> in mesos containerizer by default. This is an unfortunate legacy behavior
>> and is insecure. If you do have environment variables that you want to pass
>> to the executors, you can set it explicitly by using the
>> `--executor_environment_variables` agent flag.
>>
>> Starting from 0.30, we will no longer allow executors to inherit
>> environment variables from the agent. In other words,
>> `--executor_environment_variables` will be set to “{}” by default. If you
>> do depend on the original behavior, please set
>> `--executor_environment_variables` flag explicitly.
>>
>> Let us know if you have any comments or concerns.
>>
>> Thanks,
>> Gilbert
>>
>
>
>
> --
> Cheers,
>
> Zhitao Li
>

Re: Executors no longer inherit environment variables from the agent

Posted by Zhitao Li <zh...@gmail.com>.
Is LIBPROCESS_IP going to be an exception to this? Some executors are using
this variable as an alternative of implementing their own IP detection
logic AFAIK so this behavior would break them.

On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io> wrote:

> Hi,
>
> TL;DR Executors will no longer inherit environment variables from the
> agent by default in 0.30.
>
> Currently, executors are inheriting environment variables form the agent
> in mesos containerizer by default. This is an unfortunate legacy behavior
> and is insecure. If you do have environment variables that you want to pass
> to the executors, you can set it explicitly by using the
> `--executor_environment_variables` agent flag.
>
> Starting from 0.30, we will no longer allow executors to inherit
> environment variables from the agent. In other words,
> `--executor_environment_variables` will be set to “{}” by default. If you
> do depend on the original behavior, please set
> `--executor_environment_variables` flag explicitly.
>
> Let us know if you have any comments or concerns.
>
> Thanks,
> Gilbert
>



-- 
Cheers,

Zhitao Li

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
Rodrick,

This is unfortunate we are using environment variables that get passed into
> the executors context such as
> CHRONOS_RESOURCE_MEM
> MARATHON_APP_RESOURCE_MEM
> What will be the workaround?


Those env vars are set when launching the agent? Can you use
--executor_environment_variables to explicitly set it?

- Jie

On Thu, Mar 10, 2016 at 10:38 AM, Rodrick Brown <ro...@orchard-app.com>
wrote:

> This is unfortunate we are using environment variables that get passed
> into the executors context such as
>
> CHRONOS_RESOURCE_MEM
> MARATHON_APP_RESOURCE_MEM
>
> What will be the workaround?
>
> --
>
> *Rodrick Brown* / Systems Engineer
>
> +1 917 445 6839 / rodrick@orchardplatform.com
> <ch...@orchardplatform.com>
>
> *Orchard Platform*
>
> 101 5th Avenue, 4th Floor, New York, NY 10003
>
> http://www.orchardplatform.com
>
> Orchard Blog <http://www.orchardplatform.com/blog/> | Marketplace Lending
> Meetup <http://www.meetup.com/Peer-to-Peer-Lending-P2P/>
>
>> On Mar 8 2016, at 2:33 pm, Gilbert Song <gi...@mesosphere.io> wrote:
>>
>> Hi,
>>
>> TL;DR Executors will no longer inherit environment variables from the
>> agent by default in 0.30.
>>
>> Currently, executors are inheriting environment variables form the agent
>> in mesos containerizer by default. This is an unfortunate legacy behavior
>> and is insecure. If you do have environment variables that you want to pass
>> to the executors, you can set it explicitly by using the
>> `--executor_environment_variables` agent flag.
>>
>> Starting from 0.30, we will no longer allow executors to inherit
>> environment variables from the agent. In other words,
>> `--executor_environment_variables` will be set to “{}” by default. If you
>> do depend on the original behavior, please set
>> `--executor_environment_variables` flag explicitly.
>>
>> Let us know if you have any comments or concerns.
>>
>> Thanks,
>> Gilbert
>>
>
> *NOTICE TO RECIPIENTS*: This communication is confidential and intended
> for the use of the addressee only. If you are not an intended recipient of
> this communication, please delete it immediately and notify the sender by
> return email. Unauthorized reading, dissemination, distribution or copying
> of this communication is prohibited. This communication does not constitute
> an offer to sell or a solicitation of an indication of interest to purchase
> any loan, security or any other financial product or instrument, nor is it
> an offer to sell or a solicitation of an indication of interest to purchase
> any products or services to any persons who are prohibited from receiving
> such information under applicable law. The contents of this communication
> may not be accurate or complete and are subject to change without notice.
> As such, Orchard App, Inc. (including its subsidiaries and affiliates,
> "Orchard") makes no representation regarding the accuracy or completeness
> of the information contained herein. The intended recipient is advised to
> consult its own professional advisors, including those specializing in
> legal, tax and accounting matters. Orchard does not provide legal, tax or
> accounting advice.
>

Re: Executors no longer inherit environment variables from the agent

Posted by Connor Doyle <co...@gmail.com>.
Rodrick, in your case those environment variables are set by the
framework as part of the TaskInfo, so those shouldn't be affected by
the change.

On Thu, Mar 10, 2016 at 10:38 AM, Rodrick Brown <ro...@orchard-app.com> wrote:
> This is unfortunate we are using environment variables that get passed into
> the executors context such as
>
> CHRONOS_RESOURCE_MEM
> MARATHON_APP_RESOURCE_MEM
>
> What will be the workaround?
>
> --
>
> Rodrick Brown / Systems Engineer
>
> +1 917 445 6839 / rodrick@orchardplatform.com
>
> Orchard Platform
>
> 101 5th Avenue, 4th Floor, New York, NY 10003
>
> http://www.orchardplatform.com
>
> Orchard Blog | Marketplace Lending Meetup
>>
>> On Mar 8 2016, at 2:33 pm, Gilbert Song <gi...@mesosphere.io> wrote:
>>
>> Hi,
>>
>>
>> TL;DR Executors will no longer inherit environment variables from the
>> agent by default in 0.30.
>>
>>
>> Currently, executors are inheriting environment variables form the agent
>> in mesos containerizer by default. This is an unfortunate legacy behavior
>> and is insecure. If you do have environment variables that you want to pass
>> to the executors, you can set it explicitly by using the
>> `--executor_environment_variables` agent flag.
>>
>>
>> Starting from 0.30, we will no longer allow executors to inherit
>> environment variables from the agent. In other words,
>> `--executor_environment_variables` will be set to “{}” by default. If you do
>> depend on the original behavior, please set
>> `--executor_environment_variables` flag explicitly.
>>
>>
>> Let us know if you have any comments or concerns.
>>
>>
>> Thanks,
>>
>> Gilbert
>
>
> NOTICE TO RECIPIENTS: This communication is confidential and intended for
> the use of the addressee only. If you are not an intended recipient of this
> communication, please delete it immediately and notify the sender by return
> email. Unauthorized reading, dissemination, distribution or copying of this
> communication is prohibited. This communication does not constitute an offer
> to sell or a solicitation of an indication of interest to purchase any loan,
> security or any other financial product or instrument, nor is it an offer to
> sell or a solicitation of an indication of interest to purchase any products
> or services to any persons who are prohibited from receiving such
> information under applicable law. The contents of this communication may not
> be accurate or complete and are subject to change without notice. As such,
> Orchard App, Inc. (including its subsidiaries and affiliates, "Orchard")
> makes no representation regarding the accuracy or completeness of the
> information contained herein. The intended recipient is advised to consult
> its own professional advisors, including those specializing in legal, tax
> and accounting matters. Orchard does not provide legal, tax or accounting
> advice.



-- 
connor

Re: Executors no longer inherit environment variables from the agent

Posted by Rodrick Brown <ro...@orchard-app.com>.
This is unfortunate we are using environment variables that get passed into
the executors context such as

  

CHRONOS_RESOURCE_MEM  

MARATHON_APP_RESOURCE_MEM

  

What will be the workaround?  

  

\--

**Rodrick Brown** / Systems Engineer 

+1 917 445 6839 /
[rodrick@orchardplatform.com](mailto:charlie@orchardplatform.com)

**Orchard Platform** 

101 5th Avenue, 4th Floor, New York, NY 10003

[http://www.orchardplatform.com](http://www.orchardplatform.com/)

[Orchard Blog](http://www.orchardplatform.com/blog/) | [Marketplace Lending
Meetup](http://www.meetup.com/Peer-to-Peer-Lending-P2P/)

> On Mar 8 2016, at 2:33 pm, Gilbert Song &lt;gilbert@mesosphere.io&gt; wrote:  

>

> Hi,

>

>  

>

> TL;DR Executors will no longer inherit environment variables from the agent
by default in 0.30.

>

>  

>

> Currently, executors are inheriting environment variables form the agent in
mesos containerizer by default. This is an unfortunate legacy behavior and is
insecure. If you do have environment variables that you want to pass to the
executors, you can set it explicitly by using the
`--executor_environment_variables` agent flag.

>

>  

>

> Starting from 0.30, we will no longer allow executors to inherit environment
variables from the agent. In other words, `--executor_environment_variables`
will be set to “{}” by default. If you do depend on the original behavior,
please set `--executor_environment_variables` flag explicitly.

>

>  

>

> Let us know if you have any comments or concerns.

>

>  

>

> Thanks,

>

> Gilbert  


-- 
*NOTICE TO RECIPIENTS*: This communication is confidential and intended for 
the use of the addressee only. If you are not an intended recipient of this 
communication, please delete it immediately and notify the sender by return 
email. Unauthorized reading, dissemination, distribution or copying of this 
communication is prohibited. This communication does not constitute an 
offer to sell or a solicitation of an indication of interest to purchase 
any loan, security or any other financial product or instrument, nor is it 
an offer to sell or a solicitation of an indication of interest to purchase 
any products or services to any persons who are prohibited from receiving 
such information under applicable law. The contents of this communication 
may not be accurate or complete and are subject to change without notice. 
As such, Orchard App, Inc. (including its subsidiaries and affiliates, 
"Orchard") makes no representation regarding the accuracy or completeness 
of the information contained herein. The intended recipient is advised to 
consult its own professional advisors, including those specializing in 
legal, tax and accounting matters. Orchard does not provide legal, tax or 
accounting advice.

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
Zhitao,

Any environment variables generated by Mesos (i.e., MESOS_, LIBPROCESS_)
> will not be affected


Yes.

 explicitly call this out in UPGRADES.md


Working on it.

- Jie

On Mon, Jun 20, 2016 at 11:43 AM, Zhitao Li <zh...@gmail.com> wrote:

> Hi Jie,
>
> Can you confirm that your previous response of `Any environment variables
> generated by Mesos (i.e., MESOS_, LIBPROCESS_) will not be affected.`
> will still be honored, or explicitly call this out in UPGRADES.md?
>
> Thanks.
>
> On Mon, Jun 20, 2016 at 11:39 AM, Jie Yu <yu...@gmail.com> wrote:
>
>> FYI, from Mesos 1.0, the executors will no longer inherit environment
>> variables from the agent by default. If you have environment environment
>> variables that you want to pass in to executors, please use `--
>> executor_environment_variables` flag on the agent.
>>
>> commit ce4b3056164a804bea52810173dbd7a418d12641
>> Author: Gilbert Song <so...@gmail.com>
>> Date:   Sun Jun 19 16:01:10 2016 -0700
>>
>>     Forbid the executor to inherit from slave environment.
>>
>>     Review: https://reviews.apache.org/r/44498/
>>
>> - Jie
>>
>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>> wrote:
>>
>> > Hi,
>> >
>> > TL;DR Executors will no longer inherit environment variables from the
>> agent
>> > by default in 0.30.
>> >
>> > Currently, executors are inheriting environment variables form the
>> agent in
>> > mesos containerizer by default. This is an unfortunate legacy behavior
>> and
>> > is insecure. If you do have environment variables that you want to pass
>> to
>> > the executors, you can set it explicitly by using the
>> > `--executor_environment_variables` agent flag.
>> >
>> > Starting from 0.30, we will no longer allow executors to inherit
>> > environment variables from the agent. In other words,
>> > `--executor_environment_variables` will be set to “{}” by default. If
>> you
>> > do depend on the original behavior, please set
>> > `--executor_environment_variables` flag explicitly.
>> >
>> > Let us know if you have any comments or concerns.
>> >
>> > Thanks,
>> > Gilbert
>> >
>>
>
>
>
> --
> Cheers,
>
> Zhitao Li
>

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
Zhitao,

Any environment variables generated by Mesos (i.e., MESOS_, LIBPROCESS_)
> will not be affected


Yes.

 explicitly call this out in UPGRADES.md


Working on it.

- Jie

On Mon, Jun 20, 2016 at 11:43 AM, Zhitao Li <zh...@gmail.com> wrote:

> Hi Jie,
>
> Can you confirm that your previous response of `Any environment variables
> generated by Mesos (i.e., MESOS_, LIBPROCESS_) will not be affected.`
> will still be honored, or explicitly call this out in UPGRADES.md?
>
> Thanks.
>
> On Mon, Jun 20, 2016 at 11:39 AM, Jie Yu <yu...@gmail.com> wrote:
>
>> FYI, from Mesos 1.0, the executors will no longer inherit environment
>> variables from the agent by default. If you have environment environment
>> variables that you want to pass in to executors, please use `--
>> executor_environment_variables` flag on the agent.
>>
>> commit ce4b3056164a804bea52810173dbd7a418d12641
>> Author: Gilbert Song <so...@gmail.com>
>> Date:   Sun Jun 19 16:01:10 2016 -0700
>>
>>     Forbid the executor to inherit from slave environment.
>>
>>     Review: https://reviews.apache.org/r/44498/
>>
>> - Jie
>>
>> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
>> wrote:
>>
>> > Hi,
>> >
>> > TL;DR Executors will no longer inherit environment variables from the
>> agent
>> > by default in 0.30.
>> >
>> > Currently, executors are inheriting environment variables form the
>> agent in
>> > mesos containerizer by default. This is an unfortunate legacy behavior
>> and
>> > is insecure. If you do have environment variables that you want to pass
>> to
>> > the executors, you can set it explicitly by using the
>> > `--executor_environment_variables` agent flag.
>> >
>> > Starting from 0.30, we will no longer allow executors to inherit
>> > environment variables from the agent. In other words,
>> > `--executor_environment_variables` will be set to “{}” by default. If
>> you
>> > do depend on the original behavior, please set
>> > `--executor_environment_variables` flag explicitly.
>> >
>> > Let us know if you have any comments or concerns.
>> >
>> > Thanks,
>> > Gilbert
>> >
>>
>
>
>
> --
> Cheers,
>
> Zhitao Li
>

Re: Executors no longer inherit environment variables from the agent

Posted by Zhitao Li <zh...@gmail.com>.
Hi Jie,

Can you confirm that your previous response of `Any environment variables
generated by Mesos (i.e., MESOS_, LIBPROCESS_) will not be affected.` will
still be honored, or explicitly call this out in UPGRADES.md?

Thanks.

On Mon, Jun 20, 2016 at 11:39 AM, Jie Yu <yu...@gmail.com> wrote:

> FYI, from Mesos 1.0, the executors will no longer inherit environment
> variables from the agent by default. If you have environment environment
> variables that you want to pass in to executors, please use `--
> executor_environment_variables` flag on the agent.
>
> commit ce4b3056164a804bea52810173dbd7a418d12641
> Author: Gilbert Song <so...@gmail.com>
> Date:   Sun Jun 19 16:01:10 2016 -0700
>
>     Forbid the executor to inherit from slave environment.
>
>     Review: https://reviews.apache.org/r/44498/
>
> - Jie
>
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
> > Hi,
> >
> > TL;DR Executors will no longer inherit environment variables from the
> agent
> > by default in 0.30.
> >
> > Currently, executors are inheriting environment variables form the agent
> in
> > mesos containerizer by default. This is an unfortunate legacy behavior
> and
> > is insecure. If you do have environment variables that you want to pass
> to
> > the executors, you can set it explicitly by using the
> > `--executor_environment_variables` agent flag.
> >
> > Starting from 0.30, we will no longer allow executors to inherit
> > environment variables from the agent. In other words,
> > `--executor_environment_variables` will be set to “{}” by default. If you
> > do depend on the original behavior, please set
> > `--executor_environment_variables` flag explicitly.
> >
> > Let us know if you have any comments or concerns.
> >
> > Thanks,
> > Gilbert
> >
>



-- 
Cheers,

Zhitao Li

Re: Executors no longer inherit environment variables from the agent

Posted by Zhitao Li <zh...@gmail.com>.
Hi Jie,

Can you confirm that your previous response of `Any environment variables
generated by Mesos (i.e., MESOS_, LIBPROCESS_) will not be affected.` will
still be honored, or explicitly call this out in UPGRADES.md?

Thanks.

On Mon, Jun 20, 2016 at 11:39 AM, Jie Yu <yu...@gmail.com> wrote:

> FYI, from Mesos 1.0, the executors will no longer inherit environment
> variables from the agent by default. If you have environment environment
> variables that you want to pass in to executors, please use `--
> executor_environment_variables` flag on the agent.
>
> commit ce4b3056164a804bea52810173dbd7a418d12641
> Author: Gilbert Song <so...@gmail.com>
> Date:   Sun Jun 19 16:01:10 2016 -0700
>
>     Forbid the executor to inherit from slave environment.
>
>     Review: https://reviews.apache.org/r/44498/
>
> - Jie
>
> On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io>
> wrote:
>
> > Hi,
> >
> > TL;DR Executors will no longer inherit environment variables from the
> agent
> > by default in 0.30.
> >
> > Currently, executors are inheriting environment variables form the agent
> in
> > mesos containerizer by default. This is an unfortunate legacy behavior
> and
> > is insecure. If you do have environment variables that you want to pass
> to
> > the executors, you can set it explicitly by using the
> > `--executor_environment_variables` agent flag.
> >
> > Starting from 0.30, we will no longer allow executors to inherit
> > environment variables from the agent. In other words,
> > `--executor_environment_variables` will be set to “{}” by default. If you
> > do depend on the original behavior, please set
> > `--executor_environment_variables` flag explicitly.
> >
> > Let us know if you have any comments or concerns.
> >
> > Thanks,
> > Gilbert
> >
>



-- 
Cheers,

Zhitao Li

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
FYI, from Mesos 1.0, the executors will no longer inherit environment
variables from the agent by default. If you have environment environment
variables that you want to pass in to executors, please use `--
executor_environment_variables` flag on the agent.

commit ce4b3056164a804bea52810173dbd7a418d12641
Author: Gilbert Song <so...@gmail.com>
Date:   Sun Jun 19 16:01:10 2016 -0700

    Forbid the executor to inherit from slave environment.

    Review: https://reviews.apache.org/r/44498/

- Jie

On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io> wrote:

> Hi,
>
> TL;DR Executors will no longer inherit environment variables from the agent
> by default in 0.30.
>
> Currently, executors are inheriting environment variables form the agent in
> mesos containerizer by default. This is an unfortunate legacy behavior and
> is insecure. If you do have environment variables that you want to pass to
> the executors, you can set it explicitly by using the
> `--executor_environment_variables` agent flag.
>
> Starting from 0.30, we will no longer allow executors to inherit
> environment variables from the agent. In other words,
> `--executor_environment_variables` will be set to “{}” by default. If you
> do depend on the original behavior, please set
> `--executor_environment_variables` flag explicitly.
>
> Let us know if you have any comments or concerns.
>
> Thanks,
> Gilbert
>

Re: Executors no longer inherit environment variables from the agent

Posted by Jie Yu <yu...@gmail.com>.
FYI, from Mesos 1.0, the executors will no longer inherit environment
variables from the agent by default. If you have environment environment
variables that you want to pass in to executors, please use `--
executor_environment_variables` flag on the agent.

commit ce4b3056164a804bea52810173dbd7a418d12641
Author: Gilbert Song <so...@gmail.com>
Date:   Sun Jun 19 16:01:10 2016 -0700

    Forbid the executor to inherit from slave environment.

    Review: https://reviews.apache.org/r/44498/

- Jie

On Tue, Mar 8, 2016 at 11:33 AM, Gilbert Song <gi...@mesosphere.io> wrote:

> Hi,
>
> TL;DR Executors will no longer inherit environment variables from the agent
> by default in 0.30.
>
> Currently, executors are inheriting environment variables form the agent in
> mesos containerizer by default. This is an unfortunate legacy behavior and
> is insecure. If you do have environment variables that you want to pass to
> the executors, you can set it explicitly by using the
> `--executor_environment_variables` agent flag.
>
> Starting from 0.30, we will no longer allow executors to inherit
> environment variables from the agent. In other words,
> `--executor_environment_variables` will be set to “{}” by default. If you
> do depend on the original behavior, please set
> `--executor_environment_variables` flag explicitly.
>
> Let us know if you have any comments or concerns.
>
> Thanks,
> Gilbert
>