You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/26 07:54:14 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #13805: [WIP] refactor: replace "csv" with "file" used in common (excel) upload cases
codecov[bot] edited a comment on pull request #13805:
URL: https://github.com/apache/superset/pull/13805#issuecomment-808012476
# [Codecov](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=h1) Report
> Merging [#13805](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=desc) (73e8901) into [master](https://codecov.io/gh/apache/superset/commit/e61f5a924bd4a6fa8eacd0eab1520075f238a11d?el=desc) (e61f5a9) will **decrease** coverage by `0.51%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head 73e8901 differs from pull request most recent head d64d701. Consider uploading reports for the commit d64d701 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13805 +/- ##
==========================================
- Coverage 77.51% 77.00% -0.52%
==========================================
Files 934 934
Lines 47250 47222 -28
Branches 5881 5881
==========================================
- Hits 36628 36364 -264
- Misses 10478 10714 +236
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.17% <77.77%> (-0.81%)` | :arrow_down: |
| sqlite | `80.17% <77.77%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `88.88% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.46% <100.00%> (-1.91%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <100.00%> (-0.45%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `86.01% <100.00%> (-1.56%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13805/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=footer). Last update [e61f5a9...d64d701](https://codecov.io/gh/apache/superset/pull/13805?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org