You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/16 22:25:47 UTC
[GitHub] [superset] ktmud opened a new pull request #19227: chore: upgrade pre-commit hooks and prettier
ktmud opened a new pull request #19227:
URL: https://github.com/apache/superset/pull/19227
### SUMMARY
CI for pre-commit is [suddenly failing](https://github.com/apache/superset/runs/5577673372?check_suite_focus=true). https://github.com/apache/superset/pull/19156 bypassed it by fixing the error as the `mypy` hook in pre-commit suggests, but the same error was not reproducible locally. Let's just upgrade all pre-commit hooks and see if the inconsistency between CI and local env persist.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19227: chore: upgrade pre-commit hooks and prettier
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1069733878
⚠️ @ktmud Your base branch `master` has just also updated `superset/migrations`.
❗ **Please consider rebasing your branch to avoid db migration conflicts.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19227: chore: upgrade mypy check in pre-commit
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1071038739
# [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19227](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16d5f34) into [master](https://codecov.io/gh/apache/superset/commit/4b34817b195fe93aa0bffd211bc978966a4aee4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b34817) will **increase** coverage by `14.62%`.
> The diff coverage is `81.81%`.
> :exclamation: Current head 16d5f34 differs from pull request most recent head 8542eaa. Consider uploading reports for the commit 8542eaa to get more accurate results
```diff
@@ Coverage Diff @@
## master #19227 +/- ##
===========================================
+ Coverage 52.11% 66.74% +14.62%
===========================================
Files 1666 1668 +2
Lines 64197 64279 +82
Branches 6496 6496
===========================================
+ Hits 33458 42901 +9443
+ Misses 29057 19696 -9361
Partials 1682 1682
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.66% <54.54%> (+<0.01%)` | :arrow_up: |
| mysql | `81.98% <81.81%> (?)` | |
| postgres | `82.01% <81.81%> (?)` | |
| presto | `52.51% <54.54%> (+<0.01%)` | :arrow_up: |
| python | `82.44% <81.81%> (+29.51%)` | :arrow_up: |
| sqlite | `81.78% <81.81%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.77% <33.33%> (+41.10%)` | :arrow_up: |
| [superset/charts/data/api.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvYXBpLnB5) | `89.80% <100.00%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `90.90% <100.00%> (+43.56%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.51% <100.00%> (+62.79%)` | :arrow_up: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.83% <100.00%> (+8.33%)` | :arrow_up: |
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | `82.24% <100.00%> (+10.28%)` | :arrow_up: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `88.88% <0.00%> (ø)` | |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `91.48% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.87% <0.00%> (+0.31%)` | :arrow_up: |
| ... and [299 more](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4b34817...8542eaa](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19227: chore: upgrade mypy check in pre-commit
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1071038739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19227: chore: upgrade mypy check in pre-commit
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1071038739
# [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19227](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16d5f34) into [master](https://codecov.io/gh/apache/superset/commit/4b34817b195fe93aa0bffd211bc978966a4aee4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b34817) will **increase** coverage by `14.62%`.
> The diff coverage is `81.81%`.
> :exclamation: Current head 16d5f34 differs from pull request most recent head 8542eaa. Consider uploading reports for the commit 8542eaa to get more accurate results
```diff
@@ Coverage Diff @@
## master #19227 +/- ##
===========================================
+ Coverage 52.11% 66.74% +14.62%
===========================================
Files 1666 1668 +2
Lines 64197 64279 +82
Branches 6496 6496
===========================================
+ Hits 33458 42901 +9443
+ Misses 29057 19696 -9361
Partials 1682 1682
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.66% <54.54%> (+<0.01%)` | :arrow_up: |
| mysql | `81.98% <81.81%> (?)` | |
| postgres | `82.01% <81.81%> (?)` | |
| presto | `52.51% <54.54%> (+<0.01%)` | :arrow_up: |
| python | `82.44% <81.81%> (+29.51%)` | :arrow_up: |
| sqlite | `81.78% <81.81%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.77% <33.33%> (+41.10%)` | :arrow_up: |
| [superset/charts/data/api.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvYXBpLnB5) | `89.80% <100.00%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `90.90% <100.00%> (+43.56%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.51% <100.00%> (+62.79%)` | :arrow_up: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.83% <100.00%> (+8.33%)` | :arrow_up: |
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | `82.24% <100.00%> (+10.28%)` | :arrow_up: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `91.48% <0.00%> (ø)` | |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `88.88% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.87% <0.00%> (+0.31%)` | :arrow_up: |
| ... and [299 more](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4b34817...8542eaa](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #19227: chore: upgrade mypy check in pre-commit
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #19227:
URL: https://github.com/apache/superset/pull/19227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #19227: chore: upgrade mypy check in pre-commit
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #19227:
URL: https://github.com/apache/superset/pull/19227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19227: chore: upgrade pre-commit hooks and prettier
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1071038739
# [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19227](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c71093) into [master](https://codecov.io/gh/apache/superset/commit/02ef9ca4cd60d0d05f0afd2cebc1cabb83dfd4df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02ef9ca) will **decrease** coverage by `0.15%`.
> The diff coverage is `86.84%`.
```diff
@@ Coverage Diff @@
## master #19227 +/- ##
==========================================
- Coverage 66.73% 66.58% -0.16%
==========================================
Files 1668 1668
Lines 64277 64276 -1
Branches 6496 6496
==========================================
- Hits 42896 42798 -98
- Misses 19699 19796 +97
Partials 1682 1682
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.65% <63.46%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.50% <61.53%> (-0.01%)` | :arrow_down: |
| python | `82.12% <96.15%> (-0.31%)` | :arrow_down: |
| sqlite | `81.77% <94.23%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/dashboard/components/FilterBoxMigrationModal.tsx](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckJveE1pZ3JhdGlvbk1vZGFsLnRzeA==) | `33.33% <0.00%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <ø> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `100.00% <ø> (ø)` | |
| [superset/cli/celery.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2NlbGVyeS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/cli/examples.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2V4YW1wbGVzLnB5) | `0.00% <ø> (ø)` | |
| [superset/cli/importexport.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2ltcG9ydGV4cG9ydC5weQ==) | `80.00% <ø> (ø)` | |
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <ø> (ø)` | |
| [superset/cli/thumbnails.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3RodW1ibmFpbHMucHk=) | `0.00% <ø> (ø)` | |
| [superset/columns/models.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29sdW1ucy9tb2RlbHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/commands/base.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvYmFzZS5weQ==) | `100.00% <ø> (ø)` | |
| ... and [121 more](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [02ef9ca...7c71093](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19227: chore: upgrade pre-commit hooks and prettier
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19227:
URL: https://github.com/apache/superset/pull/19227#issuecomment-1071038739
# [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19227](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c71093) into [master](https://codecov.io/gh/apache/superset/commit/02ef9ca4cd60d0d05f0afd2cebc1cabb83dfd4df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02ef9ca) will **decrease** coverage by `0.15%`.
> The diff coverage is `86.84%`.
```diff
@@ Coverage Diff @@
## master #19227 +/- ##
==========================================
- Coverage 66.73% 66.58% -0.16%
==========================================
Files 1668 1668
Lines 64277 64276 -1
Branches 6496 6496
==========================================
- Hits 42896 42798 -98
- Misses 19699 19796 +97
Partials 1682 1682
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.65% <63.46%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.50% <61.53%> (-0.01%)` | :arrow_down: |
| python | `82.12% <96.15%> (-0.31%)` | :arrow_down: |
| sqlite | `81.77% <94.23%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/dashboard/components/FilterBoxMigrationModal.tsx](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckJveE1pZ3JhdGlvbk1vZGFsLnRzeA==) | `33.33% <0.00%> (ø)` | |
| [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <ø> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `100.00% <ø> (ø)` | |
| [superset/cli/celery.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2NlbGVyeS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/cli/examples.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2V4YW1wbGVzLnB5) | `0.00% <ø> (ø)` | |
| [superset/cli/importexport.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2ltcG9ydGV4cG9ydC5weQ==) | `80.00% <ø> (ø)` | |
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <ø> (ø)` | |
| [superset/cli/thumbnails.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3RodW1ibmFpbHMucHk=) | `0.00% <ø> (ø)` | |
| [superset/columns/models.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29sdW1ucy9tb2RlbHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/commands/base.py](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvYmFzZS5weQ==) | `100.00% <ø> (ø)` | |
| ... and [121 more](https://codecov.io/gh/apache/superset/pull/19227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [02ef9ca...7c71093](https://codecov.io/gh/apache/superset/pull/19227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org