You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/08 19:25:09 UTC

[GitHub] [spark] srowen commented on issue #23882: [SPARK-26979][PYTHON] Add missing string column name support for some SQL functions

srowen commented on issue #23882: [SPARK-26979][PYTHON] Add missing string column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#issuecomment-471046332
 
 
   @rxin I'm tying in your comment from the mailing list:
   
   ```
   I think the general philosophy here should be Python should be the most liberal and support a column object, or a literal value. It's also super useful to support column name, but we need to decide what happens for a string column. Is a string passed in a literal string value, or a column name?
   ```
   
   I apologize, is the question whether the string can be an expression? the string is meant to just be a different way to specify the column name -- `"foo"` should be accepted like `col("foo")`.
   
   Really, this is just about standardizing the behavior that exists now. Now, all pyspark functions should work like the ones that currently accept strings or column objects. It isn't intended to change it, which I think should be a right step forward in all cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org