You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/24 22:59:06 UTC
[GitHub] [druid] clintropolis opened a new pull request #10074: update avatica to handle additional character sets over jdbc
clintropolis opened a new pull request #10074:
URL: https://github.com/apache/druid/pull/10074
Fixes #10064.
### Description
The test added to `DruidAvaticaHandlerTest` fails prior to bumping Avatica dependency version. The test added to `SqlResourceTest` was just for fun, and passed prior to updating Avatica.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #10074: update avatica to handle additional character sets over jdbc
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #10074:
URL: https://github.com/apache/druid/pull/10074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on pull request #10074: update avatica to handle additional character sets over jdbc
Posted by GitBox <gi...@apache.org>.
ccaominh commented on pull request #10074:
URL: https://github.com/apache/druid/pull/10074#issuecomment-649143249
`CalciteQueryTest.testSelectLimitWrappingAgainAkaIDontReallyQuiteUnderstandCalciteQueryPlanning` failure looks related to change:
https://travis-ci.org/github/apache/druid/jobs/701837399#L1249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org